Cover breakout port generation - #2567
Draft
ideaship wants to merge 1 commit into
Draft
Conversation
9 tasks
berendt
force-pushed
the
sonic-e2e-v2-breakout
branch
from
August 5, 2026 15:10
0acfa0a to
f7628a6
Compare
ideaship
force-pushed
the
sonic-e2e-v2-breakout
branch
from
August 5, 2026 19:51
f7628a6 to
dbf7e9d
Compare
berendt
force-pushed
the
sonic-e2e-v2-breakout
branch
from
August 6, 2026 10:56
dbf7e9d to
e9567cb
Compare
ideaship
force-pushed
the
sonic-e2e-v2-breakout
branch
from
August 6, 2026 12:10
e9567cb to
9112fb9
Compare
The bundled netbox-manager example models no breakout ports and sets no explicit interface speeds, so the generator's breakout paths and its kbps->Mbps speed normalisation were never exercised by the SONiC E2E golden test. Add two standalone leaf devices on the shared E2E rack (positions 6 and 7, taking no cabling and needing none): - e2e-breakout-derived: Eth1/1/1..4 use the device type's 100gbase-x-qsfp28 interface type with no explicit speed, so the sub-port speed is derived from the interface type. Also carries a tagged VLAN on the plain Eth1/5 port, covering the VLAN / tagged-VLAN-to-port paths. - e2e-breakout-explicit: the same four sub-ports instead carry an explicit NetBox speed of 100000000 kbps, exercising the other unit the collection step must normalise. Both must yield sub-port speed 100000 in the generated config; confirmed via the regenerated goldens (BREAKOUT_CFG and BREAKOUT_PORTS populated on both, no bare speed "100" present). This brings config_db table coverage from 30 to 32 of 38. The two devices reuse the site, location, tenant, roles, tags and custom fields already seeded by 100-base.yml, and the edgecore-9726-32d-e2e device type is ported from ab8da03a. Related-Bug: #2478 Related-Bug: #2246 Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
ideaship
force-pushed
the
sonic-e2e-v2-breakout
branch
from
August 6, 2026 12:19
9112fb9 to
c3f1efc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the series tracked in #2562, which explains the ordering and what each PR covers. Based on the preceding PR in the stack, so review only the top commits here.
First scenario overlay: devices that exercise breakout port generation, covering
BREAKOUT_CFGandBREAKOUT_PORTS, which the base fixtures leave empty.Two devices differ only in how their sub-port speed is established — one derived
from the interface type, one with an explicit NetBox speed — because the
kbps-to-Mbps conversion and the type-derivation fallback are separate code paths
that both feed breakout mode selection.