Skip to content

fix: call the react recipes by their flat names - #471

Merged
retr0h merged 1 commit into
mainfrom
fix/goreleaser-flat-recipes
Sep 3, 2026
Merged

fix: call the react recipes by their flat names#471
retr0h merged 1 commit into
mainfrom
fix/goreleaser-flat-recipes

Conversation

@retr0h

@retr0h retr0h commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Docker Publish fails on every push to main:

⨯ build failed after 0s  error=exit status 1  message=hook failed: command failed
cmd=just  output=error: justfile does not contain submodule `react`

Cause

When osapi-justfiles reorganized, this repository's justfile moved from mod? submodules to flat import? modules, so the recipes became react-deps and react-build. .goreleaser.yaml still calls the old names:

before:
  hooks:
    - just react::deps
    - just react::build

That hook runs before every build, so the job dies before compiling anything. Nothing to do with the change that happened to trigger the run.

Why it survived the earlier sweep

The sweep that renamed every other call site searched --include='*.yml'. This file is .yaml. I have re-swept every osapi-io repository plus meshx, grind and tlock with no extension filter: this was the only remaining :: call anywhere.

Verification

just --list shows both recipes under the new names:

react-build             # Production build
react-deps              # Install all dependencies

just react-deps now resolves and runs, rather than failing to resolve. It exits on a missing bun locally; CI installs it with oven-sh/setup-bun@v2 in the same job.

🤖 Generated with Claude Code

https://claude.ai/code/session_013oR5Gt9WPTTdPKdnShdL7L

The justfile moved to flat imports when osapi-justfiles reorganized, so
`react::deps` and `react::build` no longer exist. GoReleaser still
called them, and its hook runs before every build, so Docker Publish
failed on every push to main with "justfile does not contain submodule
`react`".

The sweep that renamed the other call sites matched `*.yml` and missed
this file, which is `.yaml`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013oR5Gt9WPTTdPKdnShdL7L
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         484      484           
  Lines       22877    22877           
=======================================
  Hits        22865    22865           
  Misses         12       12           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4bb11...29cddca. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@retr0h
retr0h merged commit 7b74e2d into main Sep 3, 2026
12 checks passed
@retr0h
retr0h deleted the fix/goreleaser-flat-recipes branch September 3, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant