fix: call the react recipes by their flat names - #471
Merged
Conversation
The justfile moved to flat imports when osapi-justfiles reorganized, so `react::deps` and `react::build` no longer exist. GoReleaser still called them, and its hook runs before every build, so Docker Publish failed on every push to main with "justfile does not contain submodule `react`". The sweep that renamed the other call sites matched `*.yml` and missed this file, which is `.yaml`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013oR5Gt9WPTTdPKdnShdL7L
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 484 484
Lines 22877 22877
=======================================
Hits 22865 22865
Misses 12 12 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker Publishfails on every push tomain:Cause
When osapi-justfiles reorganized, this repository's justfile moved from
mod?submodules to flatimport?modules, so the recipes becamereact-depsandreact-build..goreleaser.yamlstill calls the old names:That hook runs before every build, so the job dies before compiling anything. Nothing to do with the change that happened to trigger the run.
Why it survived the earlier sweep
The sweep that renamed every other call site searched
--include='*.yml'. This file is.yaml. I have re-swept every osapi-io repository plus meshx, grind and tlock with no extension filter: this was the only remaining::call anywhere.Verification
just --listshows both recipes under the new names:just react-depsnow resolves and runs, rather than failing to resolve. It exits on a missingbunlocally; CI installs it withoven-sh/setup-bun@v2in the same job.🤖 Generated with Claude Code
https://claude.ai/code/session_013oR5Gt9WPTTdPKdnShdL7L