mariadb: explict pid file for mysqld.init - #30488
Conversation
Formality Check: Suggestions AvailableWe checked this pull request against the contribution guidelines. Here is what needs your attention:
|
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
bdd77022"mariadb: explict pid file for mysqld.init" — subject typo:explict→explicit.bdd77022— body sentence "I hope have pid-file having a default value of an empty string" is ungrammatical; the PR body's phrasing ("I hope to change pid-file to having a default value of an empty string") reads correctly.
Generated by Claude Code
With MariaDB upstream [MDEV-37284](https://jira.mariadb.org/browse/MDEV-37284) I hope have pid-file having a default value of an empty string. That won't work for the current init file. If there isn't a pid-file specified in the configuration, fall back to explicitly set the pid-file to a filename inside the same directory as the default socket. Fixing this eliminates the only discoverable implementation that used the default pid-file value and its hostname based name rather than an explicit value. Signed-off-by: Daniel Black <daniel@mariadb.org>
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
2c746070— body says "If there isn't a pid-file specified in the configuration, fall back to ...", but the code falls back only whenmysqld --help --verbosereports an emptypid-file, which it cannot distinguish from a configured one; today it always reports the hostname-based built-in default, so the fallback is unreachable until MDEV-37284 lands and the "eliminates ... its hostname based name" claim does not hold yet. Reword to describe the empty-default condition.
Generated by Claude Code
|
|
||
| pidfile="" | ||
|
|
There was a problem hiding this comment.
nit: dropping pidfile="" makes mariadb_get_pidfile's [ -z "$pidfile" ] guard honour a pidfile inherited from the caller's environment, which then lands in --pid-file=; it also leaves a stray double blank line here (and another at lines 28-29).
| pidfile="" | |
| pidfile="" | |
Generated by Claude Code
2 participants
📦 Package Details
Maintainer: @miska
Description:
With MariaDB upstream MDEV-37284 I hope to change pid-file to having a default value of an empty string. That won't work for the current init file.
Explicitly set the pid-file to a filename inside the same directory as the default socket.
Fixing this eliminates the only findable implementation that used the default pid-file value and its hostname based name rather than an explicit value.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.