igmpproxy: support new phyint options in init script - #30486
Conversation
5bb8c4c to
832aafe
Compare
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
832aafe"igmpproxy: update the uci config" — no UCI config is updated:files/igmpproxy.configis untouched, so the newratelimit/threshold/whitelist/blacklistoptions ship undocumented whilealtnetandverboseare shown there. Add them to the sample config, or retitle to describe the init-script change.832aafebody —thresholdis also made configurable but is not listed; and "stopped dropping SSDP by default" describes an opt-out that remains available, whereas the diff deletes the rule with no way to re-enable it.
The three red build jobs (x86_64, arm_cortex-a15, mips_24kc) fail in the feed setup step (wget: exited with error 8 / UNTRUSTED signature fetching packages.adb), not on this package — looks like CI infrastructure, not this PR.
Generated by Claude Code
832aafe to
0a94455
Compare
made ratelimit and threshold configurable added whitelist and blacklist made SSDP firewall dropping configurable increase pkg release Signed-off-by: Ivan Klichenko <ivan@int4.cc>
0a94455 to
f610c34
Compare
RewardedIvan
changed the title
| igmp_add_firewall_routing() { | ||
| config_get direction $1 direction | ||
| config_get zone $1 zone | ||
| config_get fw_drop_ssdp $1 fw_drop_ssdp |
There was a problem hiding this comment.
/etc/config/igmpproxy is listed in conffiles, so an existing install keeps its old config on upgrade, fw_drop_ssdp is unset, and the SSDP drop rule silently disappears. Default it to 1, and use config_get_bool so true/on/yes are accepted like quickleave in igmp_header.
| config_get fw_drop_ssdp $1 fw_drop_ssdp | |
| config_get_bool fw_drop_ssdp $1 fw_drop_ssdp 1 |
Generated by Claude Code
| for whitelist in $whitelists; do | ||
| echo -e "\twhitelist $whitelist" >> /var/etc/igmpproxy.conf | ||
| done | ||
| elif [ -n "$blacklists" ]; then |
There was a problem hiding this comment.
A phyint that sets both list whitelist and list blacklist now gets every blacklist entry silently dropped from the generated conf, with no diagnostic. Either emit both lists, or keep the exclusivity and log it (e.g. procd_append_param error) so the discarded config is visible.
Generated by Claude Code
| config phyint | ||
| option network lan | ||
| option zone lan | ||
| option fw_drop_ssdp 1 |
There was a problem hiding this comment.
nit: fw_drop_ssdp is the only one of the five new options that reaches the sample config; ratelimit, threshold, whitelist and blacklist ship undiscoverable. Add commented examples for them here, the way verbose is documented on line 3.
Generated by Claude Code
2 participants
📦 Package Details
Maintainer: @nbd168
Description:
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am