Add script to create testdata ZIP for multi-file slide; sort version 2 testdata slides after version 1 - #159
Merged
Merged
Conversation
There are multiple footguns when doing it by hand: files could be set read-only, owner/group IDs could be included, compression could be disabled, or a top-level directory could be included (as is conventional for other kinds of dist archives). Add a script that creates the ZIP file correctly and also prints the resulting SHA-256 for convenience. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
`foo.zip` sorts after `foo-v2.zip`, but `foo` sorts before `foo-v2`. Sort HTML indexes on filename stems instead of entire filenames. Drop redundant sorting of directory names in top-level index. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Member
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are multiple footguns when creating ZIPs by hand: files could be set read-only, owner/group IDs could be included, compression could be disabled, or a top-level directory could be included (as is conventional for other kinds of dist archives). Add a script that creates the ZIP file correctly and also prints the resulting SHA-256 for convenience.
When creating the openslide-testdata HTML indexes,
foo.zipsorts afterfoo-v2.zip, butfoosorts beforefoo-v2. Sort indexes on filename stems instead of entire filenames.