Skip to content

Improve exception names #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgilbert merged 1 commit into from
Aug 1, 2026
Merged

Improve exception names #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions _scripts/sync-releases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class Docs:
)


class SyncReleasesException(Exception):
class SyncError(Exception):
pass


Expand Down Expand Up @@ -134,9 +134,7 @@ def main() -> None:
expected_hash = artifact['digest'].replace('sha256:', '')
found_hash = sha256(resp.content).hexdigest()
if expected_hash != found_hash:
raise SyncReleasesException(
f'SHA-256 {found_hash} != {expected_hash}'
)
raise SyncError(f'SHA-256 {found_hash} != {expected_hash}')

# unpack
docdir = DOCROOT / proj.docs.subdir
Expand Down
6 changes: 3 additions & 3 deletions demo/_synctiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class StatusMetadata(TypedDict):
stamp: str | None


class SyncTilesException(Exception):
class SyncError(Exception):
pass


Expand Down Expand Up @@ -715,7 +715,7 @@ def retile_slide(
# Tile slide
slide_info = context['slides'].get(slide_relpath.as_posix())
if slide_info is None:
raise SyncTilesException(f'No such slide {slide_relpath}')
raise SyncError(f'No such slide {slide_relpath}')
metadata = sync_slide(
context['stamp'], storage, slide_relpath, slide_info, workers
)
Expand Down Expand Up @@ -851,4 +851,4 @@ def finish_retile(ctxfile: TextIO, summarydir: Path) -> None:
elif args.cmd == 'finish':
finish_retile(args.context_file, args.summary_dir)
else:
raise SyncTilesException('unimplemented subcommand')
raise SyncError('unimplemented subcommand')