TRT-2364: Update Sippy Chat DB schema docs to remove eliminated matview - #3930
TRT-2364: Update Sippy Chat DB schema docs to remove eliminated matview#3930mstaeble wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@mstaeble: This pull request references TRT-2364 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mstaeble The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tip For best results, initiate chat on the files or code changes.
You are interacting with an AI system. |
8769164 to
0ff1f01
Compare
|
@coderabbitai full review |
|
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
prow_job_runs_report_matview was dropped in TRT-2814 and replaced by direct prow_job_runs/prow_jobs queries, but the Sippy Chat agent's schema documentation still described the old matview (including a stale "timestamp is bigint epoch millis" claim that is exactly the kind of schema drift TRT-2364 was meant to eliminate). Update the docs and the affected example query to match the current schema, and note that pg_matviews is now empty. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
0ff1f01 to
35e3ce8
Compare
|
Scheduling required tests: |
|
@mstaeble: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@coderabbitai full review |
|
|
@coderabbitai full review |
|
Summary
prow_job_runs_report_matviewwas eliminated in TRT-2814 and replaced by directprow_job_runs/prow_jobsqueries, but the Sippy Chat agent's schema documentation (chat/sippy_agent/tools/database_query.py) still described the old matview — including a stale "timestamp is bigint epoch millis" claim, which is exactly the kind of schema drift TRT-2364 was meant to eliminate for LLM/agent consumers of the schema.This updates the docs to describe the current schema only (no discussion of what used to exist), including the affected example queries and
prow_job_runs's partitioning by(prow_job_release, timestamp).Test plan
python3 -c "import ast; ast.parse(...)")