Skip to content

TRT-2364: Update Sippy Chat DB schema docs to remove eliminated matview - #3930

Open
mstaeble wants to merge 1 commit into
openshift:mainfrom
mstaeble:sippy-chat-schema-docs
Open

TRT-2364: Update Sippy Chat DB schema docs to remove eliminated matview#3930
mstaeble wants to merge 1 commit into
openshift:mainfrom
mstaeble:sippy-chat-schema-docs

Conversation

@mstaeble

@mstaeble mstaeble commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

prow_job_runs_report_matview was eliminated in TRT-2814 and replaced by direct prow_job_runs/prow_jobs queries, but the Sippy Chat agent's schema documentation (chat/sippy_agent/tools/database_query.py) still described the old matview — including a stale "timestamp is bigint epoch millis" claim, which is exactly the kind of schema drift TRT-2364 was meant to eliminate for LLM/agent consumers of the schema.

This updates the docs to describe the current schema only (no discussion of what used to exist), including the affected example queries and prow_job_runs's partitioning by (prow_job_release, timestamp).

Test plan

  • Verified the file still parses as valid Python (python3 -c "import ast; ast.parse(...)")
  • Manually reviewed the rewritten example queries for correctness against the current schema

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 20, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 20, 2026

Copy link
Copy Markdown

@mstaeble: This pull request references TRT-2364 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

prow_job_runs_report_matview was eliminated in TRT-2814 and replaced by direct prow_job_runs/prow_jobs queries, but the Sippy Chat agent's schema documentation (chat/sippy_agent/tools/database_query.py) still described the old matview — including a stale "timestamp is bigint epoch millis" claim, which is exactly the kind of schema drift TRT-2364 was meant to eliminate for LLM/agent consumers of the schema.

This updates the docs and the affected example query to match the current schema, and notes that pg_matviews is now empty.

Test plan

  • Verified the file still parses as valid Python (python3 -c "import ast; ast.parse(...)")
  • Manually reviewed the rewritten example query for correctness against the current schema

@coderabbitai ignore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstaeble

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@openshift-ci-robot A Jira maintainer must set the target version for TRT-2364 to 5.1.0. This warning does not require a source-code change.

You are interacting with an AI system.

@mstaeble
mstaeble force-pushed the sippy-chat-schema-docs branch 4 times, most recently from 8769164 to 0ff1f01 Compare August 21, 2026 03:17
@mstaeble
mstaeble marked this pull request as ready for review August 21, 2026 03:19
@mstaeble mstaeble changed the title [WIP] TRT-2364: Update Sippy Chat DB schema docs to remove eliminated matview TRT-2364: Update Sippy Chat DB schema docs to remove eliminated matview Aug 21, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2026
@mstaeble

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@openshift-ci
openshift-ci Bot requested review from deads2k and smg247 August 21, 2026 03:20
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 43 minutes.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@mstaeble, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e706f573-04fd-46d0-b00a-73df4afda329

📥 Commits

Reviewing files that changed from the base of the PR and between 706919e and 35e3ce8.

📒 Files selected for processing (1)
  • chat/sippy_agent/tools/database_query.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

prow_job_runs_report_matview was dropped in TRT-2814 and replaced by
direct prow_job_runs/prow_jobs queries, but the Sippy Chat agent's
schema documentation still described the old matview (including a
stale "timestamp is bigint epoch millis" claim that is exactly the
kind of schema drift TRT-2364 was meant to eliminate). Update the
docs and the affected example query to match the current schema, and
note that pg_matviews is now empty.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mstaeble
mstaeble force-pushed the sippy-chat-schema-docs branch from 0ff1f01 to 35e3ce8 Compare August 21, 2026 03:20
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@mstaeble: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 35e3ce8 link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mstaeble

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 58 minutes.

@mstaeble

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 59 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants