Skip to content

OCPBUGS-105407: Promoted vSphere network jobs from CNU to default - #83655

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
vr4manta:OCPBUGS-105407
Aug 19, 2026
Merged

OCPBUGS-105407: Promoted vSphere network jobs from CNU to default#83655
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
vr4manta:OCPBUGS-105407

Conversation

@vr4manta

@vr4manta vr4manta commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

OCPBUGS-105407

Changes

  • Updated vSphere network periodicals to not be CNU

Summary by CodeRabbit

The PR updates vSphere multi-network E2E jobs in OpenShift CI for nightly 4.22, 4.23, 5.0, and 5.1 releases.

These jobs no longer use the CustomNoUpgrade feature set or enable the VSphereMultiNetworks feature gate. They remain configured with MULTI_NIC_IPI.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references Jira Issue OCPBUGS-105407, which is invalid:

  • expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "5.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-105407

Changes

  • Updated vSphere network periodicals to not be CNU

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 19, 2026
@openshift-ci
openshift-ci Bot requested review from petr-muller and smg247 August 19, 2026 11:20
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 893b6f33-81a9-44b3-a27f-94f88d01266c

📥 Commits

Reviewing files that changed from the base of the PR and between 1a56bda and 6a527ec.

📒 Files selected for processing (4)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml
💤 Files with no reviewable changes (4)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

This pull request removes explicit VSphereMultiNetworks feature-gate and CustomNoUpgrade feature-set settings from the vSphere multi-network nightly test configuration in four release YAML files. The MULTI_NIC_IPI setting stays enabled.

Changes

vSphere multi-network nightly configuration

Layer / File(s) Summary
Remove explicit feature toggles
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml, ...4.23.yaml, ...5.0.yaml, ...5.1.yaml
Each vSphere multi-network test config removes FEATURE_GATES=VSphereMultiNetworks and FEATURE_SET: CustomNoUpgrade. The existing MULTI_NIC_IPI setting remains in place.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 6a527

This localized configuration change promotes the vSphere network jobs to the default set without any actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes promoting vSphere network jobs from CNU to the default configuration, matching the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit only removes two YAML environment entries from four vSphere jobs; it adds or changes no Ginkgo test titles.
Test Structure And Quality ✅ Passed The pull request changes only four YAML job configurations; it adds or modifies no Ginkgo test code, so the stated test-quality requirements do not apply.
Microshift Test Compatibility ✅ Passed The diff only removes FEATURE_GATES and CustomNoUpgrade from four YAML jobs; it adds no Ginkgo tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The diff changes only four YAML job configurations and adds no Ginkgo tests or test declarations, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only removes FEATURE_GATES and FEATURE_SET from four CI YAML test entries; it adds or modifies no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The commit changes only four YAML job configurations; it adds no OTE binary or process-level stdout writes covered by this check.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only four YAML job configurations and adds no Ginkgo tests or test code, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The PR only deletes VSphereMultiNetworks and CustomNoUpgrade YAML settings; no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto comparison changes are present.
Container-Privileges ✅ Passed The parent-to-HEAD diff contains only eight deletions of FEATURE_GATES and FEATURE_SET; it adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR only deletes feature settings from four YAML jobs; it adds no logging or sensitive data, and the existing report templates remain unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vr4manta

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references Jira Issue OCPBUGS-105407, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

OCPBUGS-105407

Changes

  • Updated vSphere network periodicals to not be CNU

Summary by CodeRabbit

The PR updates vSphere multi-network E2E jobs in OpenShift CI for nightly 4.22, 4.23, 5.0, and 5.1 releases.

These jobs no longer use the CustomNoUpgrade feature set or enable the VSphereMultiNetworks feature gate. They remain configured with MULTI_NIC_IPI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references Jira Issue OCPBUGS-105407, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-multi-network N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.1-e2e-vsphere-ovn-multi-network N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-multi-network N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-4.23-e2e-vsphere-ovn-multi-network N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2026
@mfbonfigli

Copy link
Copy Markdown
Contributor

/lgtm

@vr4manta

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-multi-network

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfbonfigli, petr-muller, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2026
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 19, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 1bb438d into openshift:main Aug 19, 2026
15 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@vr4manta: Jira Issue OCPBUGS-105407: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-105407 has not been moved to the MODIFIED state.

Details

In response to this:

OCPBUGS-105407

Changes

  • Updated vSphere network periodicals to not be CNU

Summary by CodeRabbit

The PR updates vSphere multi-network E2E jobs in OpenShift CI for nightly 4.22, 4.23, 5.0, and 5.1 releases.

These jobs no longer use the CustomNoUpgrade feature set or enable the VSphereMultiNetworks feature gate. They remain configured with MULTI_NIC_IPI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants