Fix trailing-slash path construction and improve POST error handling … - #37
Fix trailing-slash path construction and improve POST error handling …#37petrkotas wants to merge 1 commit into
Conversation
…in proxy tests Use strings.TrimRight to guard against double slashes when the base URL already has a trailing slash, and use t.Fatalf so the test stops on POST failure rather than logging and continuing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petrkotas The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@petrkotas: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What type of PR is this?
bug.
What this PR does / Why we need it?
Fixes the trailing slash in TA calls.
Which Jira/Github issue(s) does this PR fix?
Resolves #
Special notes for your reviewer
Pre-checks (if applicable)