CORS-4550: Promote GCD to Default

[patrickdillon]

Move GCD to default featureset. Promoted via SBAR.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@patrickdillon: This pull request references CORS-4550 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Move GCD to default featureset. Promoted via SBAR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f68ba461-7c4b-41b1-9c53-5285b58d9523

📥 Commits

Reviewing files that changed from the base of the PR and between 33f9e5d and 4912562.

📒 Files selected for processing (3)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The change enables GCPSovereignCloudInstall in the default feature set and in the Hypershift and SelfManagedHA default manifests. It updates OSStreams to enable the SelfManaged profile while retaining preview enablement for Hypershift. The feature matrix reflects these settings. OKD remains unchanged.

Possibly related PRs

• openshift/api#2993: Updates FeatureGateOSStreams and Hypershift feature-gate manifests in the opposite direction.
• openshift/api#2989: Modifies OSStreams configuration in the feature declarations and Hypershift manifests.

Suggested reviewers: everettraven, joelspeed

Merge Risk: ⚪ Minimal · up to 49125

This change promotes GCD to the default featureset without any identified merge-blocking correctness, security, availability, or deployment risk; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the promotion of GCD to the default featureset, which matches the primary objective and changes.
Description check	✅ Passed	The description directly states that GCD moves to the default featureset and identifies the SBAR promotion.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff changes only features.md and two static YAML manifests; it adds no Go test files or Ginkgo title expressions, so no check failure applies.
Test Structure And Quality	✅ Passed	The complete PR diff changes only feature declarations, documentation, and generated YAML; it adds or modifies no Ginkgo tests or cluster operations.
Microshift Test Compatibility	✅ Passed	The PR diff changes only feature documentation and feature-gate YAML. It adds no Ginkgo e2e tests or test references that require MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only feature metadata and manifests. The diff adds no test paths or Ginkgo declarations, so this SNO test check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only feature-gate registration, documentation, and feature-gate payload lists; the diff adds no deployment/controller code or topology scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a feature-gate declaration and generated YAML/Markdown; its diff introduces no process-level code or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only feature-gate YAML data and Markdown; the exact diff adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The master-to-HEAD diff only changes feature-gate metadata and generated manifests; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto code, or secret comparisons.
Container-Privileges	✅ Passed	The HEAD^ diff changes only feature-matrix entries and FeatureGate status lists; added lines contain no privilege fields, and both manifests parse as kind FeatureGate.
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes only feature-gate declarations and generated manifests. The diff adds no logging code or sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration	33f9e5d	link	true	/test integration
ci/prow/verify	33f9e5d	link	true	/test verify
ci/prow/verify-feature-promotion	33f9e5d	link	true	/test verify-feature-promotion
ci/prow/unit	33f9e5d	link	true	/test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

Also needs

Suggested change

	enable(inDefault(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
	enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).

[JoelSpeed]

Could you please link the SBAR and the installer side promotion PR please?