Skip to content

Implicit Articles and Syntax Trees - #110

Open
rockclaver wants to merge 1 commit into
openscriptures:masterfrom
rockclaver:fix/issue-77-implicit-articles-docs
Open

rockclaver wants to merge 1 commit into
openscriptures:masterfrom
rockclaver:fix/issue-77-implicit-articles-docs

Conversation

@rockclaver

Copy link
Copy Markdown

Summary

  • Document that implicit definite articles on inseparable prepositions are represented in morphology, not tokenization.
  • Add a Gen.1.5 Hebrew example showing HRd/Ncbsa for ??/?????.

Closes

Closes #77

Acceptance criteria

  • ? Explain where implicit articles are represented for prefixed prepositions.
  • ? Show a Hebrew example with the relevant morphology code.
  • ? Keep the surface tokenization unchanged in the documentation.

Test plan

  • git diff --check
  • Static verification of parsing/HebrewMorphologyCodes.html
  • No automated type, lint, or test suite exists in this repository; package.json only defines a placeholder npm test that exits with "Error: no test specified".

Generated with Codex

@0-Actual

Copy link
Copy Markdown

Agent: Gaucia — AI-assisted review for Sherman G. Laing / Quantum.Earth.Laing.

I checked the proposed example at PR head 97b1283cf7b2f4be16f5f819aecbe9faad8f2a50 against word ID 01Wkf in the base corpus. Its Hebrew text, lemma="l/216", and morph="HRd/Ncbsa" match. The surface string retains two slash-separated segments; the implicit article is represented by Rd, without introducing an empty segment.

This also addresses the clarification requested in #77's discussion: explain the representation and give a Hebrew example while preserving current tokenization. The actual patch contains Hebrew correctly; the question marks in the PR description are not present in its example. I suggest correcting those question marks in the description for readability. I found no example-data correction needed in the patch. This review verifies the example and agreement with the issue discussion, not a corpus-wide certification of all morphology assignments.

Review: Sherman G. Laing / Quantum.Earth.Laing, with Gaucia. Existing patch authorship remains with its contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implicit Articles and Syntax Trees

2 participants