Skip to content

Fix the structure of Ps.93.4, by treating the Azla Legarmeh in the first word as a SHALISH - #108

Open
noamraph wants to merge 1 commit into
openscriptures:masterfrom
noamraph:ps-93-4-structure-azla-legarmeh
Open

noamraph wants to merge 1 commit into
openscriptures:masterfrom
noamraph:ps-93-4-structure-azla-legarmeh

Conversation

@noamraph

@noamraph noamraph commented May 4, 2025

Copy link
Copy Markdown

(Note: this is following this message.)

Currently, this is the structure of Ps.93.4:
image
It doesn't make sense according to the meaning of the word. I fixed it so it looks like this:
image
This is very similar to Ps.93.3:
image

I think that the issue is that since Azla Legarmeh replaces Oleh VeYored when it comes at the first word in the verse, this was treated as an Oleh VeYored. However, from the actual meaning of the words, I think that it's clear that it should be treated as a regular Azla Legarmeh (Like in verse 3).

Is a change in the XML file how to fix this, or is the XML file autogenerated from another file?

If this is accepted, I guess that a next step would be to look for other Azla Legarmeh at the first word to see if they need to be fixed as well. I wonder if there's a way to automatically know if the Azla Legarmeh at the first word should be treated like an Oleh VeYored or not.

…rst word as a SHALISH, even though it's in the first word.
@jag3773 jag3773 assigned jdejoode and unassigned jdejoode May 6, 2025
@jag3773

jag3773 commented May 6, 2025

Copy link
Copy Markdown
Member

@jdejoode or @DavidTroidl Can you review this PR?

@0-Actual

Copy link
Copy Markdown

Agent: Gaucia — AI-assisted technical review for Sherman G. Laing / Quantum.Earth.Laing.

I checked PR head 4dce9f80036439b86ac403201bda54546591a969 against base 3d15126fb1ef74867fc1434be1942e837932691f and verified that the proposed patch changes only word ID 19AHF in Psalm 93:4, from n="2" to n="1.0.0". The word's text, lemma, morphology, ID, and the remaining XML content are preserved.

For the question about where to edit: the repository's structure/OshbVerse/Script/Structure.js loads the WLC book XML directly; ElementMarkup.js reads the n attributes, and the verse-layout code groups the resulting lines by those codes. The separate structure/write_wlc_chapters.py copies existing chapter XML rather than deriving these n values from accents. Thus this patch targets data consumed by the viewer. This source trace does not establish whether an external authoring process must also be updated.

That is a technical scope review, not approval of the proposed cantillation interpretation. The existing request for specialist review remains appropriate; I would not generalize a new automatic rule from this one verse.

Review: Sherman G. Laing / Quantum.Earth.Laing, with Gaucia. Proposed correction remains credited to noamraph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants