Upgrade pip before installing torch in scbutterfly - #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Both scButterfly components stopped building, which is the whole of the current CI failure on
main-- every other component is green in both Build and Test.The failing line is the torch install:
Nothing about it changed;
typing_extensionsdid. The chain:--index-urlreplaces PyPI, so every transitive dependency has to come off the PyTorch index too.typing-extensions. The PyTorch index links back to the PyPI-hostedtyping_extensions-4.15.0-py3-none-any.whl.python:3.9predates PEP 503 name normalisation in that check, so it discards the wheel:has inconsistent Name: expected 'typing-extensions', but metadata has 'typing_extensions'.typing_extensions4.15 builds withflit_core<4,>=3.11, which is not on the PyTorch index, and the build-dependency install inherits the same--index-url.ERROR: No matching distribution found for flit_core<4,>=3.11.So it is a stale-pip bug that a third-party release tripped, not a change on our side and not the base images -- these two components are the only ones still on
python:3.9rather thanopenproblems/base_pytorch_nvidia:1.Upgrading pip first fixes it: modern pip accepts the wheel, never reaches the sdist, and never needs
flit_core.Verified locally: both images build, and
viash testpasses forscbutterfly_trainandscbutterfly_predict.Leaving the
python:3.9+ torch 1.13.1 stack alone here. Moving scButterfly ontobase_pytorch_nvidia:1means Python 3.12, torch 2.11 and numpy 2, against a component currently pinned tonumpy==1.23.5/scanpy==1.9.3/anndata==0.8.0/episcanpy==0.3.2-- worth doing, but not as the fix that unbreaks CI.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!