Drop the pip-installed cmake from the pytorch base image - #48
Merged
Conversation
* Install cmake via apt and uninstall the pip package. Its shims in /usr/local/bin shadow /usr/bin/cmake, and they fail with ModuleNotFoundError when a build calls them from inside a pip build isolation environment -- which is why `pip install cellplm` could not build louvain. * Add a test checking that cmake, cpack and ctest resolve to /usr/bin * Bump the version to 1.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
cmakeusable again inbase_pytorch_nvidia.The nvcr image runs
pip install cmake, which putscmake,cpackandctestshims in/usr/local/bin. Those shadow apt's/usr/bin/cmake, because/usr/local/bincomes firston
PATH. The shims themselves look fine --cmake --versionworks -- but they break assoon as a build calls them from inside a pip build isolation environment, where
site-packagesis no longer onsys.path:Reproduced on the published image, where it stops
cellplmfrom buildinglouvain:Changes:
cmakevia apt andpip uninstall -y cmake. Uninstalling the package rather thanremoving the one shim also clears
cpackandctest, which would otherwise be leftbehind pointing at nothing.
test_cmake.py, checking that all three resolve to the apt-provided binaries.viash testpasses 3/3, andpip install cellplmnow gets throughlouvain-0.7.1. Withthis in, the workaround in the cellplm component (
apt: [cmake]plusrm -f /usr/local/bin/cmake) can go.🤖 Generated with Claude Code