fix(web): retain clipboard fallback and credit overlapping PR contributions - #439
Merged
Conversation
Restore QuinnWan's #352 clipboard fallback with selection restoration, honest failure feedback, and component cleanup. Preserve current exact-turn cancellation and request deadlines; cover body stalls and request cleanup inspired by seekskyworld's #377. Credit #352, #377, and #358 in README. Refs #438, #352, #377, #358 Co-authored-by: QuinnWan <144975606+somewan820@users.noreply.github.com> Co-authored-by: seekskyworld <djh1813553759@gmail.com>
github-actions
Bot
added
the
documentation
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
The React migration already carries most of #352's workbench design and stronger implementations of #377's request deadlines and #358's Pi-native cancellation. One useful behavior was missing: Copy assumed the Clipboard API existed and succeeded. It now falls back to the original temporary-textarea mechanism, restores focus and selection, reports failure honestly, and permits retry without leaking feedback timers after unmount.
README credits QuinnWan (@somewan820) for the restored UI baseline and clipboard fallback, and @seekskyworld for the timeout and cancellation proposals. The integration commit includes their verified original author identities as co-authors.
Scope and compatibility
Validation
bun run checkpassed.bun run test: 1,442 Node tests passed, 1 skipped; 92 Vitest tests passed.bun run test:web:e2e: 4 passed with the built production workbench; no live-provider runtime acceptance claimed.Closes #438. Refs #352, #377, #358; those source PRs remain available as contribution history.