Skip to content

8396849: [Linux] OpenType variable fonts cause problems with styled logical fonts - #33761

Closed
prrace wants to merge 5 commits into
openjdk:masterfrom
prrace:fvar_ol10
Closed

prrace wants to merge 5 commits into
openjdk:masterfrom
prrace:fvar_ol10

Conversation

@prrace

@prrace prrace commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

This fix resolves problems with styles of logical fonts on OL 10.2 - and any other Linux where a font variation is used as the first component of the Linux sans/serif/monospace desktop fonts.

It skips such initial fonts - as identified by [wght] in the name, which seems sufficient for now, although not fool proof.
The alternative is opening the fonts to see if they are variation fonts during the process of gathering the names.
That is something we don't really want to do. That's why we use fontconfig.
If we need to refine this later, we will, but hopefully before that is needed we'll have proper variation support.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8396849: [Linux] OpenType variable fonts cause problems with styled logical fonts (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/33761/head:pull/33761
$ git checkout pull/33761

Update a local copy of the PR:
$ git checkout pull/33761
$ git pull https://git.openjdk.org/jdk.git pull/33761/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33761

View PR using the GUI difftool:
$ git pr show -t 33761

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/33761.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Nov 5, 2026

Copy link
Copy Markdown

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8396849: [Linux] OpenType variable fonts cause problems with styled logical fonts

Reviewed-by: kizune, azvegint

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title 8396849 8396849: [Linux] OpenType variable fonts cause problems with styled logical fonts. Nov 5, 2026
@openjdk openjdk Bot added the client client-libs-dev@openjdk.org label Nov 5, 2026
@openjdk

openjdk Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Nov 5, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: client. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Nov 5, 2026
@prrace prrace changed the title 8396849: [Linux] OpenType variable fonts cause problems with styled logical fonts. 8396849: [Linux] OpenType variable fonts cause problems with styled logical fonts Nov 5, 2026
@mlbridge

mlbridge Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Webrevs

@azuev-java azuev-java left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed look good and i verified that after removing the font configuration file generated by the unfixed version this fix indeed resolves the originally reported problem on Oracle Linux 10.2.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Nov 11, 2026
@prrace

prrace commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk

openjdk Bot commented Nov 12, 2026

Copy link
Copy Markdown

Going to push as commit c678ea9.
Since your change was applied there have been 108 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Nov 12, 2026
@openjdk openjdk Bot closed this Nov 12, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 12, 2026
@openjdk

openjdk Bot commented Nov 12, 2026

Copy link
Copy Markdown

@prrace Pushed as commit c678ea9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tianon

tianon commented Nov 18, 2026 •

Copy link
Copy Markdown

Hi @tianon, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user tianon" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants