Repository navigation
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 83 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Webrevs
|
azuev-java
left a comment
There was a problem hiding this comment.
Changed look good and i verified that after removing the font configuration file generated by the unfixed version this fix indeed resolves the originally reported problem on Oracle Linux 10.2.
|
/integrate |
|
Going to push as commit c678ea9.
Your commit was automatically rebased without conflicts. |
|
Hi @tianon, thanks for making a comment in an OpenJDK project! All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user tianon" for the summary. If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.
Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use. |
This fix resolves problems with styles of logical fonts on OL 10.2 - and any other Linux where a font variation is used as the first component of the Linux sans/serif/monospace desktop fonts.
It skips such initial fonts - as identified by [wght] in the name, which seems sufficient for now, although not fool proof.
The alternative is opening the fonts to see if they are variation fonts during the process of gathering the names.
That is something we don't really want to do. That's why we use fontconfig.
If we need to refine this later, we will, but hopefully before that is needed we'll have proper variation support.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/33761/head:pull/33761$ git checkout pull/33761Update a local copy of the PR:
$ git checkout pull/33761$ git pull https://git.openjdk.org/jdk.git pull/33761/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 33761View PR using the GUI difftool:
$ git pr show -t 33761Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/33761.diff
Using Webrev
Link to Webrev Comment