Skip to content

super minor fix for map hover in create lobby - #5227

Open
Boostry123 wants to merge 1 commit into
openfrontio:mainfrom
Boostry123:Bug/mapHover
Open

super minor fix for map hover in create lobby#5227
Boostry123 wants to merge 1 commit into
openfrontio:mainfrom
Boostry123:Bug/mapHover

Conversation

@Boostry123

Copy link
Copy Markdown
Contributor

Before opening a PR: discuss new features on Discord first, and file bugs or small improvements as issues. You must be assigned to an approved issue — unsolicited PRs will be auto-closed.

Add approved & assigned issue number here:

Resolves #(issue number)

Description:

Super minor bug: when creating a new lobby, if you hover over the maps, it would act weird. This minor change simply improves the UX.

The hover bug:

mapHoverBug.mp4

Describe the PR.

Please complete the following:

  • [x ] I have added screenshots for all UI updates
  • [ x] I process any text displayed to the user through translateText() and I've added it to the en.json file
  • [x ] I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME
Boostry

@Boostry123
Boostry123 requested a review from a team as a code owner September 2, 2026 07:50
@github-actions github-actions Bot added the small-fix Small fix (≤ 50 lines) — auto-applied by PR gate label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 83325da0-d5d6-4cd0-82a0-17db48946e84

📥 Commits

Reviewing files that changed from the base of the PR and between edb14a5 and 6b4f703.

📒 Files selected for processing (1)
  • src/client/components/map/MapDisplay.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

The unselected map card now enlarges slightly on hover instead of moving upward.

Changes

Map card hover behavior

Layer / File(s) Summary
Update unselected hover style
src/client/components/map/MapDisplay.ts
The unselected card hover effect now uses scale-105 instead of upward translation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6b4f7

This localized UI change adjusts map-card hover behavior without affecting data, permissions, interfaces, persistence, deployment, or system communication. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: ryanbarlow97

Poem

Map cards rest in rows of light
A hover makes one grow in sight
No upward leap, no sudden flight
Just gentle scale, precise and bright
The map stays still, the card feels right

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the map hover fix in the create-lobby interface. It is concise and related to the main change.
Description check ✅ Passed The description explains that the pull request fixes unusual map-hover behavior when creating a lobby. It is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

🤖 Claude Code Review

Verdict: No issues found — safe to merge. Findings: 0 critical, 0 major, 0 minor.

This PR changes a single line in src/client/components/map/MapDisplay.ts, swapping the non-selected map card's hover effect from hover:-translate-y-1 to hover:scale-105 to fix the reported hover glitch. It's a purely cosmetic Tailwind class change with no logic, security, i18n, or determinism implications.

Checked for:

  • Bugs / logic errors — none. The class swap is syntactically valid, doesn't conflict with the existing active:scale-95 utility (hover/active variants compose correctly), and doesn't affect the selected branch.
  • CLAUDE.md compliance — none. No user-visible text was added/changed (i18n rule N/A), no src/core files touched (determinism/test rule N/A), and no nested CLAUDE.md scopes (e.g. src/client/render/CLAUDE.md) apply to this file.

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small-fix Small fix (≤ 50 lines) — auto-applied by PR gate

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant