fix: refresh Android course structure when requested - #498
Conversation
|
Thanks for the pull request, @edschema! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Closing to make some changes. Will open new pr afterwards |
Description
Fixes Android course-structure refresh requests that could return the first cached Flow emission instead of requesting an updated structure.
When
getCourseStructure(courseId, isNeedRefresh = true)runs online, it now uses a dedicated request path withCache-Control: no-cache. Offline refreshes remain cache-only, and ordinary non-refresh callers keep the existing cache-first behavior.Out of Scope
This is the Android prerequisite for later course-routing work. It does not add Inbox or routing behavior, redesign sibling status, Dates, progress, or enrollment caches, change production callers, or modify server contracts, Room schema, or migrations.
Change Log
Notes
Fresh and cache-first requests intentionally use separate coalescers so a refresh cannot join a request using the cache-first header. The public
CourseInteractorinterface andCourseApicontract are unchanged.Tests Done
CoalescingCacheTest,CourseRepositoryFreshTest, andCourseInteractorFreshTest:course:testDevelopDebugUnitTest:app:assembleDevelopDebugdetektAllAI Assistance
AI tools were used to aid in diagnosis, planning, implementation, testing, and review. All work was checked and reviewed.