fix: use PEP 508 syntax for credentials-themes requirement - #3004
fix: use PEP 508 syntax for credentials-themes requirement#3004GlugovGrGlib wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @GlugovGrGlib! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The legacy egg fragment with a version specifier (#egg=edx_credentials_themes==0.5.6) was never valid and modern pip (>=26) now rejects it with InvalidEggFragment instead of a warning. This has crashed pip-compile in the weekly 'Upgrade Requirements' workflow on every run since 2026-02-24, so the requirements bot has been unable to open new upgrade PRs. Switch to a PEP 508 direct reference so make upgrade works again.
a08cd36 to
4d3f59a
Compare
Description
The weekly automated "Upgrade Requirements" workflow has failed on every scheduled run since 2026-02-24 (last success: 2026-02-17, which produced #2959). Each run crashes in
make upgradeon the very firstpip-compileinvocation:The cause is this line in
requirements/base.in:An
#egg=fragment may only contain a bare project name; the==0.5.6version specifier was never valid. Older pip only warned about it, but the workflow installs the latest pip, and pip >= 26 turned this long-deprecated pattern into a hard error — sopip-compilecrashes at the parsing stage before resolving anything.This PR switches the line to a PEP 508 direct reference
Verified with pip 26.1.2: the old line reproduces the exact
InvalidEggFragmentfailure from the workflow logs, the new line parses correctly toedx_credentials_themes.Impact
Once merged, the next scheduled bot run will succeed again and open a fresh requirements-upgrade PR. That will also supersede #2959, which is currently unmergeable because its pinned
virtualenv==20.37.0has since been deleted from PyPI.Note: the workflow's failure notifications go to a 2U-internal OpsGenie address, which is likely why 6+ months of weekly failures went unnoticed.