Make SPDX headers consistent and complete - #63
Merged
Conversation
src/openvfs/ is one library in one directory but gave three different
licensing answers: four files GPL-3.0-or-later, openvfs.cpp
GPL-2.0-or-later, and three files in src/openvfsfuse/ with no SPDX tag
at all. libopenvfs is what downstream sync clients link against, so its
license determines the license of the combined binary they ship --
anyone doing that assessment got a different answer depending on which
file they opened first.
openvfs.cpp is aligned with the other four and with the top-level
LICENSE, the missing tags are added to main.cpp and sharedmap.{h,cpp}
(which already carried the full GPL-3 notice in prose), and the tag in
strtools.h moves above the include guard like everywhere else.
socketthread.{h,cpp} are deliberately left alone: they carry third-party
MIT code by David Lafreniere alongside the GPL-3 notice, and pinning a
single machine-readable expression on that combination is the
maintainers' call, not a drive-by fix. A REUSE.toml would make the whole
tree checkable with `reuse lint` and is worth doing as a follow-up.
toxicphreAK
force-pushed
the
split/spdx-headers
branch
from
August 27, 2026 09:06
fbf5cc0 to
188d57c
Compare
dragotin
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #54.
src/openvfs/is one library in one directory but gave three licensing answers: four filesGPL-3.0-or-later,openvfs.cppGPL-2.0-or-later, and three files insrc/openvfsfuse/with no tag at all.libopenvfsis what downstream clients link against, so its license determines the license of the combined binary they ship.openvfs.cppaligned with the other four and with the top-level LICENSE, missing tags added tomain.cppandsharedmap.{h,cpp}(which already carried the full GPL-3 notice in prose), and the tag instrtools.hmoved above the include guard like everywhere else.socketthread.{h,cpp}deliberately left alone — they carry third-party MIT code alongside the GPL-3 notice, and pinning one expression on that is your call, not a drive-by fix. AREUSE.tomlwould make the tree checkable withreuse lint; happy to do that as a follow-up if you want it.