Repository navigation
coff split: mark linker-written regions in Sections:, not as units - #14
Merged
Merged
Conversation
Instead of a `linker` attribute on a splits.txt unit, a section or sub-region in the `Sections:` group takes a bare `linker` flag: .idata$5 type:rodata vaddr:0x008A9000 end:0x008A99C0 linker dtk carves each `linker` region into its own autogenerated unit, named after the region (`linker/idata_5`, `linker/edata`), and marks that unit `linker` as before: objs.rsp leaves it out and the build config lists its ranges. The gap fill no longer splits a linker region on its symbols, since the linker writes it whole. The split fails if a splits.txt unit claims part of a `linker` region, or if generate_imports/generate_exports is on and an `.idata`/`.edata` split isn't in one. The unit-level `linker` attribute from 0.0.36 is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13, from review on openblack/bw1-decomp#449: the region is already declared in
Sections:, so mark it there instead of adding a unit for it.What dtk does with a
linkersection or sub-region:linker/idata_5,linker/rdata_debug,linker/edata);linkeras before: objs.rsp leaves it out, and the build config lists its ranges;Errors: the split fails if a splits.txt unit claims part of a
linkerregion, or ifgenerate_imports/generate_exportsis on and an.idata/.edatasplit isn't in one.Breaking change: the unit-level
linkerattribute from 0.0.36 is removed. Only the unmerged bw1-decomp#449 used it.Verified on bw1-decomp BW1W120:
cargo testpasses and clippy reports nothing new.🤖 Generated with Claude Code