Repository navigation
Fix the line editor's way picking, blurry aerials, solid objects and objects on drawn-on roads - #137
Merged
Merged
Conversation
…ack to the start A path clicked after the end of a way picked by hand was put in as a way round between the first paths of the line wherever it led back into them round the block, so the way looped back to the start with every click. It now goes where it adds the least driving, and a way round must take the place of something or mend a gap. A trip whose way is not found all the way keeps the part found, and picking by hand goes on from there instead of from nothing. The list of the way's paths opens while picking and shows more of them. A lane driven against its path's direction no longer hides the link over it. Fixes #135
With more than 64 tiles of pictures every tile's overlay went up at 512 pixels (about 60 cm a pixel on a 300 m tile), so adding the 65th tile suddenly turned all the imagery blurry, though the files in the imagery folder stay 4096 a side. Now the tile under the camera goes up at 4096, the eight round it at 2048 and the sixteen round those at 1024, following the camera; the far tiles keep what their number allows. Fixes #134
…and in a test drive Its .sco said [collision_mesh] but not [fixed], and OMSI 2 builds the collision shape only for [fixed] objects: any other is a loose body the bus drives through. A solid object now writes [fixed] beside its collision mesh (once, when the object it was made from already had one). Fixes #128
A road drawn on from the free end of another (also each new click while drawing a road on) counted its chain from 0 again, while it was linked to the road before it. A row's distance counts from the start of the chain, and the game - and the view with it - draws no row whose first object lies before its own spline by the links: an object put on the new road within the length of the road before it stood nowhere, in the editor as in the game. Further along the same road it was drawn, so some parts of a road seemed to swallow what was put on them. The new road's chain now goes on from the road it was drawn from. Fixes #131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
[1, 2, 3, 4, 2]in the new test). Now a click goes where it adds the least driving, and a way round must replace part of the way or mend a gap. When the automatic search fails between two stops, the trip keeps the part it found, and picking by hand continues from there instead of from nothing. The list of the way's paths opens while picking and is taller. A short connector driven against its path's direction no longer hides the link over it..scohad[collision_mesh]but no[fixed], and OMSI 2 only gives vehicles collision on[fixed]objects.reshape::turn_endwas removed. It has had no callers since Keep the roads after a spline when its length or heading changes. #136.Tests
cargo test --release --bin openmapper: 735 passed, 0 failed. The new tests are:a_path_past_the_end_does_not_loop_back_to_the_start, which fails on the old codea_way_found_part_of_the_way_keeps_that_parttiles_round_the_camera_stay_sharp_on_a_big_mapa_solid_object_is_fixed_and_its_collision_mesh_reads_backan_object_put_on_a_road_drawn_on_from_an_end_is_drawnpython3 tools/i18n/check.pyreports complete, since no UI text changed.Not tried in OMSI 2 itself, and not checked against the reporters' own maps.
Fixes #135
Fixes #134
Fixes #131
Fixes #130
Fixes #128