Repository navigation
stubs/jmax: 0.1.5 + fix binstall pkg-url - #6
Merged
Merged
Conversation
{ archive-suffix } already includes the leading dot, so the old template asked
GitHub for jmax-<ver>-<target>..tar.gz and cargo binstall could never find a
binary. Verified with cargo-binstall 1.26.0 (--manifest-path) that this version
installs the real jmax 0.1.5 from the v0.1.5 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the crates.io stub installer so
cargo binstall jmaxinstalls the current release.v0.1.5GitHub release (itsjmax-0.1.5-<target>.tar.gzassets).pkg-url.{ archive-suffix }already includes the leading dot, so the old template asked forjmax-<ver>-<target>..tar.gz, and binstall (no fallback whenpkg-urlis set) could never find a binary.Verified with cargo-binstall 1.26.0 (
--manifest-path, x86_64-linux): it installs the realjmax 0.1.5.cargo publish --dry-runpasses. Once this merges, the crate is published as jmax 0.1.5.