Drop and count spans ended after SimpleSpanProcessor shutdown as already_shutdown - #5512
Open
cijothomas wants to merge 1 commit into
Open
Conversation
…ady_shutdown Assisted-by: Claude Opus 4.8
cijothomas
force-pushed
the
cijothomas/simple-span-processor-already-shutdown
branch
from
August 5, 2026 20:54
9ee3855 to
85298d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5509. That PR added
already_shutdowncounting to the batch (span and log) and simple log processors, but intentionally leftSimpleSpanProcessorunchanged because it had no shutdown gate: it kept passing spans ended aftershutdown()to the (already shut down) exporter. This adds that gate, matching the other processors and the semantic conventions.After
shutdown(),SimpleSpanProcessornow drops ended spans instead of passing them to the exporter, and counts them onotel.sdk.processor.span.processedwitherror.type=already_shutdown.Note this is a behavior change: spans ended after
shutdown()are no longer passed to the exporter.