[CONFIGURATION] validate and update config files to yaml schema 1.1.0 - #4374
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4374 +/- ##
==========================================
- Coverage 81.79% 81.78% -0.01%
==========================================
Files 493 493
Lines 19474 19474
==========================================
- Hits 15926 15924 -2
- Misses 3548 3550 +2 🚀 New features to boost your workflow:
|
…ests of the example_yaml to run kitchen-sink and extensions yaml files
…nown civitweb race on shutdown
…nges from open-telemetry#4374 and should be reviewed in that PR]
|
Really confused by:
Here is PR 4374, what is this about ? |
dbarker
left a comment
There was a problem hiding this comment.
The yaml files have updates for 1.1:
- Move TLS settings under the
tls:key - Remove zipkin as it is no longer in the schema
- add
event_to_span_event_bridge/development(commented out pending #4309 - update
logger_configurator/developmentto add the current config keys. - add
max_export_batch_size/developmentto the periodic reader - update
meter_configurator/developmentandtracer_configurator/developmentkey fromdisabledtoenabled - add
id_generatorto tracer provider - update the sampler field to instantiate all supported samplers
- remove
peerfrom the instrumentation section as it has been removed from the schema.
marcalff
left a comment
There was a problem hiding this comment.
LGTM, excellent tooling improvement.
My intent was to test #4367 with this PR's changes early by adding them to both PRs. The review of these yaml file updates should be done in this PR. Once this PR is merged, #4367 will show far fewer files/lines changed. |
|
CI failures:
Most likely due to adding the magic |
|
Label ok-to-merge: feel free to merge once the shelltest ci passes. |
Followup to: #4340
Adds a script and test to validate the otel-config yaml files against the schema and update files as needed.
Changes
opentelemetry-configurationschema versionexamplesandfunctional.kitchen-sink.yamlandextnesions.yamlto the 1.1 schema--testarg.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes