POC for zelUnloadDrivers - #502
Draft
rwmcguir wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>
+ Thus the zelUnloadDriver is a oneshot Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC Only for design discussion, not for merging yet.
May need to be moved to L0 Spec discssuion
At current drivers unloaded, cannot be reloaded due to initial implementation. This is the first major limitation in this design. A design decision needs to be made here, if we support re-loading, or effectively treat this as a banned driver during this process execution.
Driver ordering is impacted, not re-ordering but a HOLE will develop in the schema, so if N devices loaded, and N-1 devices are left, it would not be clear to user which N's are valid. It appears very unsafe to attempt re-ordering after users may have driver handles, so list compaction seems like a bad idea. Returning UNITIALIZED seems best for now, or in the future UNLOADED is a potential upgrade. This specifically affects zer* API's if the first driver is unloaded, they will then be redirected to the next valid driver.