Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new query documentation page for SSMM “Stock in Air” (in-transit, in_progress) deliveries so analysts can copy/paste the SQL into Metabase and understand its intent and parameters.
Changes:
- Added
Care/Operations/stock_in_air_ssmm.mdwith Purpose/Parameters/Query/Notes sections. - Documented a Metabase
datefilter intended to bind toesd.created_date. - Included joins to product, origin/destination locations, and creator user details.
Suppressed comments (1)
Care/Operations/stock_in_air_ssmm.md:42
- There’s an extra leading space before this
JOIN, which makes indentation inconsistent within the query block.
JOIN emr_facilitylocation destination
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (3)
Care/Operations/stock_in_air_ssmm.md:41
- Indentation is inconsistent in this JOIN block (extra leading space before
JOINand misalignedAND), which makes the query harder to read/copy as a snippet. Align it with the surrounding JOIN/ON indentation.
JOIN emr_facilitylocation origin
ON origin.id = edo.origin_id
AND origin.deleted = FALSE
Care/Operations/stock_in_air_ssmm.md:44
- Indentation is inconsistent in this JOIN block (extra leading space before
JOINand misalignedAND), which makes the query harder to read/copy as a snippet. Align it with the surrounding JOIN/ON indentation.
JOIN emr_facilitylocation destination
ON destination.id = edo.destination_id
AND destination.deleted = FALSE
Care/Operations/stock_in_air_ssmm.md:26
- The selected column is
esd.created_date(delivery record created date), but the aliasdelivery_dateimplies an actual delivery/movement date. Renaming the alias to reflect what it is will avoid confusion for readers and downstream Metabase column names.
esd.created_date AS delivery_date,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.