Skip to content

Add documentation for Stock in Air query at SSMM - #145

Open
sonzsara wants to merge 2 commits into
mainfrom
ENG-886
Open

Add documentation for Stock in Air query at SSMM#145
sonzsara wants to merge 2 commits into
mainfrom
ENG-886

Conversation

@sonzsara

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new query documentation page for SSMM “Stock in Air” (in-transit, in_progress) deliveries so analysts can copy/paste the SQL into Metabase and understand its intent and parameters.

Changes:

  • Added Care/Operations/stock_in_air_ssmm.md with Purpose/Parameters/Query/Notes sections.
  • Documented a Metabase date filter intended to bind to esd.created_date.
  • Included joins to product, origin/destination locations, and creator user details.
Suppressed comments (1)

Care/Operations/stock_in_air_ssmm.md:42

  • There’s an extra leading space before this JOIN, which makes indentation inconsistent within the query block.
 JOIN emr_facilitylocation destination

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Care/Operations/stock_in_air_ssmm.md Outdated
Comment thread Care/Operations/stock_in_air_ssmm.md
Comment thread Care/Operations/stock_in_air_ssmm.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (3)

Care/Operations/stock_in_air_ssmm.md:41

  • Indentation is inconsistent in this JOIN block (extra leading space before JOIN and misaligned AND), which makes the query harder to read/copy as a snippet. Align it with the surrounding JOIN/ON indentation.
 JOIN emr_facilitylocation origin
	ON origin.id = edo.origin_id
   AND origin.deleted = FALSE

Care/Operations/stock_in_air_ssmm.md:44

  • Indentation is inconsistent in this JOIN block (extra leading space before JOIN and misaligned AND), which makes the query harder to read/copy as a snippet. Align it with the surrounding JOIN/ON indentation.
 JOIN emr_facilitylocation destination
	ON destination.id = edo.destination_id
   AND destination.deleted = FALSE

Care/Operations/stock_in_air_ssmm.md:26

  • The selected column is esd.created_date (delivery record created date), but the alias delivery_date implies an actual delivery/movement date. Renaming the alias to reflect what it is will avoid confusion for readers and downstream Metabase column names.
	esd.created_date AS delivery_date,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants