Repository navigation
Restrict SSH host key algorithms to the configured host key types (#892) - #893
Merged
Merged
Conversation
Member
|
This looks good, thank you. I wonder if we can also test this behavior in the integration test, e.g. by providing a non-ecdsa key instead? |
Contributor
Author
|
Good idea, thanks! I added a fourth step to the SSH integration test: the backup container is restarted with the server’s ED25519 host key pinned (the test server offers both ECDSA and ED25519), and the test checks that the backup is uploaded. Without the fix it fails with ssh: host key mismatch. |
Member
|
This is now released in v2.50.1, thanks a lot 🎩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892
When
SSH_HOST_PUBLIC_KEYorSSH_KNOWN_HOSTS_FILEis used,HostKeyAlgorithmsis now set to the type(s) of the configured host key(s). Previously the client negotiated its default preference (ECDSA first), so a pinned ED25519 key never matched when the server also offered ECDSA.rsa-sha2-256/512)