Repository navigation
chore(security): qs 6.17.0 for GHSA-6pq8-jhm2-2vcw - #207
Merged
Merged
Conversation
Refresh pnpm-lock.yaml so that qs resolves to 6.17.0 (was 6.16.0 under express and superagent, 6.16.1 under body-parser) for GHSA-6pq8-jhm2-2vcw (moderate: qs.stringify with arrayFormat 'comma' throws an uncaught TypeError on array elements carrying a non-callable own toString, DoS; fixed in 6.16.1). express ^5.3.0 depends on qs ^6.16.0, so the fixed version is in range. Lockfile only; no manifest or code change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
y1o1
added a commit
that referenced
this pull request
Oct 29, 2026
…7c94c792 pnpm-lock.yaml is merge=binary, so the merge conflicted once develop took qs 6.17.0 (#207). Resolved by taking develop's lockfile and re-applying this PR's two bumps with `pnpm update @biomejs/biome@2.6.2 jose@6.2.13`: the result differs from develop by exactly this PR's biome/jose hunks and from the Dependabot head by exactly #207's qs hunks. Frozen install, audit (low), lint, build, typecheck and tests pass on the merged tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
y1o1
pushed a commit
that referenced
this pull request
Oct 29, 2026
@biomejs/biome 2.5.15 -> 2.6.2, jose 6.2.12 -> 6.2.13 (Dependabot). pnpm-lock.yaml regenerated on top of develop after #207 (qs 6.17.0): develop's lockfile plus exactly this PR's biome/jose hunks. Frozen install, audit (low), lint, build, typecheck and tests pass on the merged tree.
y1o1
added a commit
that referenced
this pull request
Nov 7, 2026
Write the 0.10.3 CHANGELOG section from git log v0.10.2..224afcc: Security for qs 6.17.0 (GHSA-6pq8-jhm2-2vcw, #207), and Changed (development only) for biome, @types/node and jose (#206, #208). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
express).qs6.7.0–6.16.0 is affected by GHSA-6pq8-jhm2-2vcw (moderate, CVSS 5.3):qs.stringifywitharrayFormat: 'comma'throws an uncaughtTypeErroron array elements carrying a non-callable owntoString(DoS). Fixed in 6.16.1. It reaches the proxy throughexpress ^5.3.0, whoseqs ^6.16.0range already admits the fix. Lockfile only (pnpm update qs); no manifest or code change.pnpm run auditgate is--audit-level=high, so this advisory never turned CI red here.pnpm audit --audit-level=lowondevelop(b56bb45) reports it; on this branch it is clean.qsentries only (6.16.0 and 6.16.1 collapse into one 6.17.0);superagent(dev) follows the same move.expresscalls onlyqs.parse, and the proxy does not useqsitself. Same advisory as chore(security): qs ^6.16.1 for GHSA-6pq8-jhm2-2vcw auth.policy-verifier#327.Test plan
pnpm install --frozen-lockfile,pnpm audit --audit-level=low(clean),pnpm run audit,pnpm run lint,pnpm run build,pnpm run typecheck,pnpm test(49 files, 1635 passed, 3 skipped) locally on Node 26.12.1codex review --base b56bb45): no actionable regressionsNot in this PR
pnpm-lock.yaml, so it is rebased after this merges, not merged alongside.🤖 Generated with Claude Code