Skip to content

chore: use import.meta.dirname in devtools-app config - #858

Merged
harlan-zw merged 1 commit into
mainfrom
fix/dirname
Aug 15, 2026
Merged

chore: use import.meta.dirname in devtools-app config#858
harlan-zw merged 1 commit into
mainfrom
fix/dirname

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

spotted this remnant of cjs utils (which aren't present in esm) here - only working because we load modules with jiti, but this isn't guaranteed in future.

@danielroe
danielroe requested a review from harlan-zw August 14, 2026 20:07
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
scripts-playground Ready Ready Preview Aug 14, 2026 8:08pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 60d0e9ac-e63a-41e3-ac6c-e874251f3c12

📥 Commits

Reviewing files that changed from the base of the PR and between d0324e7 and 463cc21.

📒 Files selected for processing (1)
  • packages/devtools-app/nuxt.config.ts

📝 Walkthrough

Walkthrough

The Nuxt configuration now uses import.meta.dirname to resolve the global stylesheet path and the Nitro publicDir path. Both changes replace __dirname.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 463cc

This is a narrowly scoped configuration update replacing a CommonJS-style dirname reference with the ESM-compatible equivalent; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main configuration change from __dirname to import.meta.dirname.
Description check ✅ Passed The description explains the CommonJS utility issue and the reason for removing reliance on jiti.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dirname

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/scripts@858

commit: 463cc21

@harlan-zw
harlan-zw merged commit e6cd4c3 into main Aug 15, 2026
19 checks passed
@harlan-zw
harlan-zw deleted the fix/dirname branch August 15, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants