Repository navigation
Conversation
Closes #3850 The `path-meta` transformer gave every file a fallback title taken from its basename, so `.navigation` files got "Navigation". To undo that, `generateNavigationTree` cleared any `.navigation` title equal to "navigation" (case-insensitive). That also cleared titles users had set to "Navigation" on purpose. Changes: - `path-meta`: added a `generateTitleFromBasename()` helper. It never generates a title for `.navigation` files (Markdown and YAML both reach the transformer with basename `.navigation`). - `navigation`: removed the string comparison. An empty title is now deleted from the directory config, so it can't overwrite the index page's title or the generated directory title. Explicit titles are kept as they are. Content that deliberately sets `title: Navigation` in a `.navigation` file will now show that title in the navigation tree. This is intended. Tests: - Navigation tree: an explicit "Navigation" title is kept, and an empty title falls back to the index page's title or the generated one. - path-meta: `.navigation.md` / `.navigation.yml` get no generated title, and the `generateTitleFromBasename` helper is covered.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The reported empty nested-title behavior is unchanged from the base revision, so no current-PR regression remains identified. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the main change: preserving an explicit "Navigation" title in .navigation files. |
| Description check | |
The description accurately explains the .navigation title-generation and navigation-tree changes, including fallback behavior and test coverage. |
| Linked Issues check | |
Issue #3850 requires an explicit Navigation title in .navigation.md to remain visible. generateTitleFromBasename returns no fallback title for .navigation, and generateNavigationTree no long… |
| Out of Scope Changes check | |
The changes stay within issue #3850. The path-meta helper prevents the reported basename fallback, navigation processing preserves explicit titles and handles empty-title fallback, and the added tests… |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 ESLint
-
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
src/runtime/internal/navigation.ts
-
Parsing error: Unexpected token {
src/utils/content/transformers/path-meta.ts
-
Parsing error: Unexpected token {
test/unit/generateNavigationTree.test.ts
-
Parsing error: Unexpected token {
- 1 others
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
close in favor of #3878 |
This branch was successfully deployed
1 participant
Closes #3850
The
path-metatransformer gave every file a fallback title taken from its basename, so.navigationfiles got "Navigation". To undo that,generateNavigationTreecleared any.navigationtitle equal to "navigation" (case-insensitive). That also cleared titles users had set to "Navigation" on purpose.Changes:
path-meta: added agenerateTitleFromBasename()helper. It never generates a title for.navigationfiles (Markdown and YAML both reach the transformer with basename.navigation).navigation: removed the string comparison. An empty title is now deleted from the directory config, so it can't overwrite the index page's title or the generated directory title. Explicit titles are kept as they are.Content that deliberately sets
title: Navigationin a.navigationfile will now show that title in the navigation tree. This is intended.Tests:
.navigation.md/.navigation.ymlget no generated title, and thegenerateTitleFromBasenamehelper is covered.