Skip to content

PDPS-3514: Fix sync timeouts and rate limiting on large kbs #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ykulynych wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PDPS-3514: Fix sync timeouts and rate limiting on large kbs #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97ea798
PDPS-3514: Fix sync timeouts and rate limiting on large kbs
ykulynych Nov 13, 2026
6795495
PDPS-3514: Fix Plugin Check issues and review findings
ykulynych Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .distignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
/package-lock.json
/phpunit.xml.dist
/playwright.config.ts
/playwright.scaling.config.ts
/README.md
/.DS_Store
/.phpunit.result.cache
Expand Down
86 changes: 86 additions & 0 deletions assets/css/admin.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,16 @@ body.toplevel_page_progress-agentic-rag #wpcontent {
color: var(--progress-agentic-rag-color-danger-regular);
}

.progress-agentic-rag__sync-cancel {
display: flex;
margin: 1rem 0 0 auto;
width: fit-content;
}

.progress-agentic-rag__sync-cancel[hidden] {
display: none;
}

.progress-agentic-rag__button:disabled {
background: hsl(220, 18%, 92%);
border-color: hsl(220, 18%, 88%);
Expand Down Expand Up @@ -920,6 +930,82 @@ body.toplevel_page_progress-agentic-rag #wpcontent {
width: 0;
}

.progress-agentic-rag__spinner,
.progress-agentic-rag__button--busy::before {
animation: progress-agentic-rag-spin 800ms linear infinite;
border: 2px solid currentcolor;
border-radius: 50%;
border-right-color: transparent;
box-sizing: border-box;
flex: none;
height: 1em;
width: 1em;
}

.progress-agentic-rag__button--busy::before {
content: "";
margin-right: var(--progress-agentic-rag-space-075);
}

.progress-agentic-rag__sync-banner {
align-items: center;
background: var(--progress-agentic-rag-color-light-stronger);
border: 1px solid var(--progress-agentic-rag-surface-border);
border-left: 4px solid var(--progress-agentic-rag-color-primary-regular);
border-radius: var(--progress-agentic-rag-card-border-radius);
color: var(--progress-agentic-rag-color-primary-regular);
display: flex;
gap: var(--progress-agentic-rag-space-2);
margin-bottom: var(--progress-agentic-rag-space-2);
padding: var(--progress-agentic-rag-space-2);
}

.progress-agentic-rag__sync-banner[hidden] {
display: none;
}

.progress-agentic-rag__sync-banner--done {
border-left-color: var(--progress-agentic-rag-color-success-regular);
color: var(--progress-agentic-rag-color-success-regular);
}

.progress-agentic-rag__sync-banner--done .progress-agentic-rag__spinner {
display: none;
}

.progress-agentic-rag__sync-banner-body {
flex: 1;
min-width: 0;
}

.progress-agentic-rag__sync-banner-text {
color: var(--progress-agentic-rag-color-dark-stronger);
display: flex;
flex-wrap: wrap;
gap: var(--progress-agentic-rag-space-1);
}

.progress-agentic-rag__sync-banner-text span {
color: var(--progress-agentic-rag-color-neutral-regular);
}

.progress-agentic-rag__sync-banner-percent {
font-size: var(--progress-agentic-rag-font-size-display-s);
}

@keyframes progress-agentic-rag-spin {
to {
transform: rotate( 360deg );
}
}

@media (prefers-reduced-motion: reduce) {
.progress-agentic-rag__spinner,
.progress-agentic-rag__button--busy::before {
animation-duration: 3s;
}
}

.progress-agentic-rag__sync-stats {
display: grid;
gap: var(--progress-agentic-rag-space-1);
Expand Down
142 changes: 110 additions & 32 deletions assets/js/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
const mappingContainer = document.querySelector( '[data-progress-agentic-rag-mapping-container]' );
const addMappingButton = document.querySelector( '[data-progress-agentic-rag-add-mapping]' );
const modal = document.querySelector( '[data-progress-agentic-rag-sync-modal]' );
const syncBanner = document.querySelector( '[data-progress-agentic-rag-sync-banner]' );
const syncDetailsButton = document.querySelector( '[data-progress-agentic-rag-sync-details]' );
const cancelSyncButton = document.querySelector( '[data-progress-agentic-rag-sync-cancel]' );
const appearanceForm = document.querySelector( '[data-progress-agentic-rag-widget-appearance-form]' );
const appearancePreview = document.querySelector( '[data-progress-agentic-rag-widget-preview]' );
const defaultStartButtonText = config.strings && config.strings.sync ? config.strings.sync : startButton ? startButton.textContent : '';
Expand Down Expand Up @@ -85,6 +88,7 @@
let deletePollTimer = null;
let backgroundPollTimer = null;
let syncStatus = config.initialSyncStatus || {};
let syncRunObserved = false;
let deleteStatus = config.initialDeleteStatus || {};
let backgroundSyncStatus = config.initialBackgroundSyncStatus || {};
const mappingConfig = config.mapping || { taxonomies: {}, labelsets: [] };
Expand Down Expand Up @@ -153,6 +157,9 @@

const setModalMode = ( mode ) => {
const isDelete = mode === 'delete';
if ( cancelSyncButton ) {
cancelSyncButton.hidden = isDelete || ! syncIsRunning() || ! syncStatus.cancellable;
}
const closeButton = field( selectors.closeButton );

setText( selectors.label, isDelete ? config.strings.deleteModalLabel : config.strings.syncModalLabel );
Expand Down Expand Up @@ -236,6 +243,12 @@
};

const closeModal = () => {
// The counters on this page are rendered by PHP, so show the result of a run that finished.
if ( syncRunObserved && ! syncIsRunning() ) {
window.location.reload();
return;
}

modal.hidden = true;
document.body.classList.remove( 'progress-agentic-rag-sync-open' );
if ( pollTimer && ! syncIsRunning() ) {
Expand All @@ -246,11 +259,42 @@
window.clearTimeout( deletePollTimer );
deletePollTimer = null;
}
startButton.disabled = deleteIsRunning() ? true : startButtonInitiallyDisabled;
if ( startButton ) {
startButton.disabled = deleteIsRunning() ? true : startButtonInitiallyDisabled;
}
};

const renderBanner = ( status ) => {
if ( ! syncBanner ) {
return;
}

const running = syncIsRunning();
const percent = Math.max( 0, Math.min( 100, statusNumber( status, 'percent' ) ) );
const bar = syncBanner.querySelector( '[data-progress-agentic-rag-banner-bar]' );
const set = ( selector, value ) => {
const element = syncBanner.querySelector( selector );
if ( element ) {
element.textContent = value;
}
};

// A finished run stays visible until the page is reloaded so its outcome is not lost.
syncBanner.hidden = ! running && ! syncRunObserved;
syncBanner.classList.toggle( 'progress-agentic-rag__sync-banner--done', ! running );
if ( bar ) {
bar.style.width = percent + '%';
}
set( '[data-progress-agentic-rag-banner-title]', running ? config.strings.running : config.strings.syncFinished );
set( '[data-progress-agentic-rag-banner-message]', status.message || '' );
set( '[data-progress-agentic-rag-banner-percent]', percent + '%' );
};

const renderStatus = ( status ) => {
syncStatus = status || {};
if ( cancelSyncButton ) {
cancelSyncButton.hidden = ! syncIsRunning() || ! status.cancellable;
}
if ( pollTimer ) {
window.clearTimeout( pollTimer );
pollTimer = null;
Expand All @@ -271,15 +315,22 @@
setText( selectors.current, status.current || '' );

if ( syncIsRunning() ) {
startButton.textContent = runningButtonText( status );
startButton.disabled = false;
syncRunObserved = true;
renderBanner( status );
if ( startButton ) {
startButton.textContent = runningButtonText( status );
startButton.disabled = false;
startButton.classList.add( 'progress-agentic-rag__button--busy' );
}
pollTimer = window.setTimeout( pollStatus, 2000 );
return;
}

if ( status.status !== 'starting' ) {
renderBanner( status );
if ( startButton && status.status !== 'starting' ) {
startButton.textContent = defaultStartButtonText;
startButton.disabled = startButtonInitiallyDisabled;
startButton.classList.remove( 'progress-agentic-rag__button--busy' );
}
};

Expand All @@ -299,8 +350,8 @@
try {
renderStatus( await request( 'progress_agentic_rag_manual_sync_status' ) );
} catch ( error ) {
startButton.disabled = false;
renderError( error.message );
setText( selectors.message, config.strings.pollInterrupted );
pollTimer = window.setTimeout( pollStatus, 10000 );
}
};

Expand Down Expand Up @@ -332,7 +383,9 @@
if ( deleteIsRunning() ) {
deleteSyncedButton.textContent = deleteButtonText( status );
deleteSyncedButton.disabled = false;
startButton.disabled = true;
if ( startButton ) {
startButton.disabled = true;
}
deletePollTimer = window.setTimeout( pollDeleteStatus, 2000 );
return;
}
Expand All @@ -348,7 +401,7 @@
if ( status.status !== 'starting' ) {
deleteSyncedButton.textContent = defaultDeleteButtonText;
deleteSyncedButton.disabled = deleteButtonInitiallyDisabled;
if ( ! syncIsRunning() ) {
if ( startButton && ! syncIsRunning() ) {
startButton.disabled = startButtonInitiallyDisabled;
}
}
Expand Down Expand Up @@ -809,40 +862,65 @@
} );
}

if ( startButton && modal ) {
startButton.addEventListener( 'click', async () => {
setModalMode( 'sync' );
openModal();

if ( syncIsRunning() ) {
if ( modal ) {
if ( cancelSyncButton ) {
cancelSyncButton.addEventListener( 'click', async () => {
cancelSyncButton.disabled = true;
try {
renderStatus( await request( 'progress_agentic_rag_manual_sync_status' ) );
renderStatus( await request( 'progress_agentic_rag_manual_sync_cancel' ) );
} catch ( error ) {
renderError( error.message );
window.alert( error.message );
} finally {
cancelSyncButton.disabled = false;
}
return;
}
} );
}

const postTypes = selectedPostTypes();
startButton.disabled = true;
const showSyncProgress = async () => {
setModalMode( 'sync' );
openModal();

try {
renderStatus( {
status: 'starting',
total: 0,
completed: 0,
failed: 0,
current: '',
message: config.strings.starting,
percent: 0,
} );
renderStatus( await request( 'progress_agentic_rag_manual_sync_start', { post_types: postTypes } ) );
renderStatus( await request( 'progress_agentic_rag_manual_sync_status' ) );
} catch ( error ) {
startButton.disabled = false;
renderError( error.message );
}
} );
};

if ( syncDetailsButton ) {
syncDetailsButton.addEventListener( 'click', showSyncProgress );
}

if ( startButton ) {
startButton.addEventListener( 'click', async () => {
if ( syncIsRunning() ) {
showSyncProgress();
return;
}

setModalMode( 'sync' );
openModal();

const postTypes = selectedPostTypes();
startButton.disabled = true;

try {
renderStatus( {
status: 'starting',
total: 0,
completed: 0,
failed: 0,
current: '',
message: config.strings.starting,
percent: 0,
} );
renderStatus( await request( 'progress_agentic_rag_manual_sync_start', { post_types: postTypes } ) );
} catch ( error ) {
startButton.disabled = false;
renderError( error.message );
}
} );
}
if ( syncIsRunning() ) {
renderStatus( syncStatus );
}
Expand Down
Loading
Loading