Repository navigation
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The new model=None routing and KB-scope account restrictions depend on unavailable external implementations, while local tests mock these boundaries, leaving deployed dependency contracts unverified.
No open issues 🎉
What changed in this PR
This PR lets NucliaDB agent calls inherit the Knowledge Box’s configured model instead of defaulting to Luna, while preserving explicit model overrides and validating KB scope.
Changes:
- Makes the KB source model optional and leaves default resolution to prediction.
- Passes model and KB context through routing and helper calls, requiring an explicit routing model across different KBs.
- Adds tests for model inheritance, overrides, serialization, and scope validation.
| File | Description |
|---|---|
tests/db/test_transform.py |
Verifies transformed KB agents leave the model unset. |
agents/nucliadb/tests/test_config.py |
Tests the unset default and JSON round-trip behavior. |
agents/nucliadb/tests/test_agent.py |
Tests routing, model precedence, helper calls, and scope checks. |
agents/nucliadb/src/hyperforge_nucliadb_agentic/config.py |
Makes the generative model optional for KB inheritance. |
agents/nucliadb/src/hyperforge_nucliadb_agentic/agent.py |
Propagates model and KB scope and preserves inherited defaults. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop defaulting KB source LLM calls to Luna. When no model is explicitly configured, let prediction resolve the KB’s default model and enforce account restrictions