Skip to content

Better object storage read error handling - #4016

Merged
jotare merged 1 commit into
mainfrom
restore-handling-object-storage-errors
Nov 13, 2026
Merged

jotare merged 1 commit into
mainfrom
restore-handling-object-storage-errors

Conversation

@jotare

@jotare jotare commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Description

Sometimes reading from object storage fails, the buffer can't read anything from the stream and the restore fails. Add a backoff to mitigate this

How was this PR tested?

Describe how you tested this PR.

@jotare
jotare requested review from a team as code owners November 13, 2026 11:07
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.73%. Comparing base (01888fc) to head (b8070ae).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/backups/restore.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4016      +/-   ##
==========================================
- Coverage   85.75%   85.73%   -0.02%     
==========================================
  Files         564      564              
  Lines       49459    49465       +6     
  Branches    15749    15749              
==========================================
- Hits        42412    42411       -1     
- Misses       6407     6411       +4     
- Partials      640      643       +3     
Flag Coverage Δ
nidx 81.30% <ø> (-0.04%) ⬇️
nucliadb 74.12% <83.33%> (+<0.01%) ⬆️
nucliadb-ingest 45.20% <66.66%> (+<0.01%) ⬆️
nucliadb-reader 47.58% <66.66%> (+<0.01%) ⬆️
nucliadb-search 55.62% <66.66%> (+<0.01%) ⬆️
nucliadb-standalone 48.11% <66.66%> (-0.02%) ⬇️
nucliadb-train 46.57% <66.66%> (+<0.01%) ⬆️
nucliadb-writer 49.59% <66.66%> (-0.01%) ⬇️
nucliadb_dataset 73.41% <ø> (ø)
nucliadb_models 69.43% <ø> (ø)
nucliadb_sdk 79.52% <ø> (ø)
nucliadb_telemetry 86.16% <ø> (ø)
nucliadb_utils 79.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotare
jotare merged commit d2ea91b into main Nov 13, 2026
41 checks passed
@jotare
jotare deleted the restore-handling-object-storage-errors branch November 13, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants