Skip to content

fix(nucliadb): handle empty label selection in facet counts - #166

Merged
arnaugrispg merged 1 commit into
mainfrom
PDPS-2928-unbound-variable-on-hyperforge
Nov 11, 2026
Merged

fix(nucliadb): handle empty label selection in facet counts#166
arnaugrispg merged 1 commit into
mainfrom
PDPS-2928-unbound-variable-on-hyperforge

Conversation

@arnaugrispg

@arnaugrispg arnaugrispg commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix an UnboundLocalError in inner_facets when no relevant label sets are selected.

  • Return an empty context with missing=question.
  • Record the operation as skipped instead of performed.
  • Preserve existing behavior when labels are selected.
  • Add regression tests for both branches.

Testing

  • Confirmed the empty-selection test reproduces the error before the fix.
  • Both regression cases pass after the fix.

@arnaugrispg
arnaugrispg requested a review from a team November 11, 2026 10:51
@arnaugrispg
arnaugrispg added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 62cfe37 Nov 11, 2026
4 checks passed
@arnaugrispg
arnaugrispg deleted the PDPS-2928-unbound-variable-on-hyperforge branch November 11, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ciniesta Ciniesta Ciniesta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arnaugrispg @Ciniesta