Repository navigation
Support optional connection IDs in SyncAsk - #150
Merged
arnaugrispg merged 5 commits intoSep 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical and moderate findings remain unresolved.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds optional connection_ids support for hybrid SyncAsk retrieval, allowing public resources alongside authorized synchronized content.
Changes:
- Adds optional connection ID validation.
- Implements lazy sync configuration resolution and hybrid filtering.
- Adds regression tests for hybrid authorization and caching.
| File | Summary | Findings |
|---|---|---|
agents/nucliadb/tests/test_sync.py |
Adds regression coverage for hybrid behavior. | No findings. |
agents/nucliadb/src/hyperforge_nucliadb/sync/driver.py |
Adds lazy sync configuration resolution and caching. | No findings. |
agents/nucliadb/src/hyperforge_nucliadb/sync/config_driver.py |
Makes connection IDs optional with validation. | No findings. |
agents/nucliadb/src/hyperforge_nucliadb/sync/agent.py |
Implements hybrid filtering and authorization. | Critical (4 votes): Cached hybrid configurations can incorrectly filter public resources; skip the prefilter for hybrid sources. Moderate (1 vote): Resource metadata is fetched twice, increasing request volume and latency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…og filter preservation
carlesonielfa
approved these changes
Sep 28, 2026
arnaugrispg
deleted the
PDPS-2123-blank-connection-id-in-sync-ask-agent
branch
September 29, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable hybrid SyncAsk retrieval when
connection_idsis empty, allowing public resources while securely authorizing synchronized content. Preserve restricted behavior for configured connections and add regression tests.