Repository navigation
Huginn flies home on a return, cards follow his line, and a more realistic aurora - #20
Conversation
The fly-in no longer assumes the order header, card, card. Each box the page hands the worker says what it is (header, card or text), and each card is drawn in as Huginn flies over it or makes his closest pass by it, then no later than a set time after the card before it along his line. Any number of cards now works. Coming back from another of the site's pages (the GMT or worktree docs), or by Back or Forward, the header stays put and only the title, intro and cards come in again. Huginn flies home instead: from close by in the distance, starting on the side of the card for the page left, past the cards and out over the top or a side, now and then as close as the first fly-in. The page is back within 3 s. Also keeps the skyline lift from bending his line sharply when he is only a few metres away, which made the first fly-in jerk on phones. In development, ?huginn=return or ?huginn=first picks the fly-in, and &from=/gmt/ the page to come back from. Closes #15
The GitHub and Discord icons were the theme's cyan. They now match the shield: grey ice at rest, ice on hover or focus. The focus ring and its sonar ping keep the theme's cyan.
Adds --gmt-aurora-green, --gmt-aurora-red and --gmt-aurora-fringe for the sky: oxygen's green line (557.7 nm), oxygen's red line (630 nm) and the pink-magenta of nitrogen along an active aurora's lower edge, as a camera records them.
The aurora takes its colours from the emissions, by altitude: oxygen's green from the lower border to about 200 km, its faint red above that (mostly atop tall rays), and while active, nitrogen's pink-magenta along the lower edge. A faint green airglow band sits some ten degrees above the horizon. It is mostly quiet, with a surge now and then that builds over a minute or so: brighter, more rayed, faster rays, deeper folds, the fringe and a redder top. Each load starts somewhere different along it. The water is a truer mirror. A ripple tilts the reflection by a degree or two rather than stretching it, and below the skyline the water mirrors the dark mountains or city, read from a new skyline texture. Ísafjörður shows its fjord. The skyline builder now records water seen from land between a far and a near shore, and the rebuilt Ísafjörður skyline (ridge unchanged) cuts that window into the mountains. With the mountains about 2° high across it, the fjord mirrors them, and the aurora shows as glints where ripples catch it. In development, ?aurora=active or ?aurora=calm holds it in a surge or quiet.
|
/craig-review |
There was a problem hiding this comment.
code-reviewer: minor issues
This PR makes the fly-in order kind-based and handles any number of cards. It adds a homecoming flight for return visits, with the header kept in place, and reworks the aurora shading: emission colours, activity surges, a skyline-aware water mirror and the Ísafjörður near-shore strip. I traced the target indexing, the CSS precedence between ng-return and ng-await, the near-strip vertex counts and the two-byte ridge texture packing and unpacking, and found them consistent. The only point worth checking is that the homecoming is planned in one synchronous burst on a frame. The other two findings are small suggestions.
Reviewed b1f8831 for craig-o-curtis · claude-opus-5-5 · 11 files · $1.06
Planning a homecoming can take a few milliseconds on a slow phone, so the gap after that frame says nothing about whether frames keep up. It is now left out of paceMs, so one slow plan cannot switch the fly-in to 30 fps for the rest of the visit. A missing colour token also reads as black now, not as the token before it.
Each card now states where its docs sit on this site (data-ng-path, "/gmt/"), and only that counts when picking the card the visitor came back from. Its other links, such as GitHub, may lead off the site and no longer take part. Works the same on a dev server, where the docs links still point at northguild.dev.
tokens.css is copied from GMT and would lose NorthGuild's own tokens the next time it is copied. The aurora colours move to tokens-aurora.css, imported by the sky that uses them, and tokens.css is back to the copy.
|
Thanks for the review. All three comments are addressed, one commit each, now pushed:
|
Closes #15.
Huginn and the page coming in
Header
A more realistic aurora (a nod to worktree's greens)
--gmt-aurora-green,--gmt-aurora-red,--gmt-aurora-fringe: oxygen's 557.7 nm and 630 nm lines and nitrogen's pink-magenta.Previewing (dev server only)
?huginn=returnor?huginn=firstpicks the fly-in.&from=/gmt/sets the page to come back from.?aurora=activeor?aurora=calmholds the aurora in a surge or quiet.Checks
pnpm lint && pnpm format:check && pnpm check && pnpm buildpass on each commit.