build,src: make --use-largepages a no-op - #65389
Open
joyeecheung wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
This feature has not been actively used in the wild and has always only been best-effort on systems that support it. The build changes it needs breaks WSL1 compatibility and the relocation mechanism won't work with newer V8 that remaps builtins using mremap(MREMAP_DONTUNMAP). This patch effectively removes this feature by turning the flags into no-ops. A warning will be printed if `--use-largepages=on` is used. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
force-pushed
the
remove-largepages
branch
from
August 18, 2026 16:42
4a43098 to
d1826aa
Compare
panva
approved these changes
Aug 18, 2026
richardlau
approved these changes
Aug 18, 2026
Contributor
|
You'd need to run |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65389 +/- ##
==========================================
+ Coverage 90.11% 90.13% +0.02%
==========================================
Files 752 751 -1
Lines 251861 251855 -6
Branches 47365 47358 -7
==========================================
+ Hits 226955 227021 +66
+ Misses 16238 16181 -57
+ Partials 8668 8653 -15
🚀 New features to boost your workflow:
|
lpinca
approved these changes
Aug 18, 2026
targos
approved these changes
Aug 18, 2026
legendecas
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature has not been actively used in the wild and has always only been best-effort on systems that support it. The build changes it needs breaks WSL1 compatibility and the relocation mechanism won't work with newer V8 that remaps builtins using mremap(MREMAP_DONTUNMAP).
This patch effectively removes this feature by turning the flags into no-ops. A warning will be printed if
--use-largepages=onis used.Fixes: #63735
Fixes: #64408
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7985687