Revert "fs: fix close listener leak in FileHandle streams" - #65387
Open
MikeMcC399 wants to merge 1 commit into
Open
Revert "fs: fix close listener leak in FileHandle streams"#65387MikeMcC399 wants to merge 1 commit into
MikeMcC399 wants to merge 1 commit into
Conversation
This reverts commit 8488e13. It was advised that the fix in question is broken since it will unref the handle multiple times. Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
nodejs-github-bot
added
fs
MikeMcC399
marked this pull request as ready for review
August 18, 2026 16:00
ovflowd
approved these changes
Aug 18, 2026
atlowChemi
approved these changes
Aug 18, 2026
Contributor
|
Fast-track has been requested by @ovflowd. Please 👍 to approve. |
Member
|
Removed need of CI, since we're reverting to previous code, this is known to be stable. Added fast-track. |
ronag
approved these changes
Aug 18, 2026
Member
|
Proper fix is to use eos/finished instead of 'close' listener |
panva
added
needs-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Member
The needs-ci label doesn't drive the need for CI. Removing it does absolutely nothing. CI is needed even for a revert, especially since other commits landed since that mean the codebase is not returning to a known state. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65387 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01%
==========================================
Files 752 752
Lines 251861 251849 -12
Branches 47365 47363 -2
==========================================
+ Hits 226955 226984 +29
+ Misses 16238 16192 -46
- Partials 8668 8673 +5
🚀 New features to boost your workflow:
|
lpinca
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #64227
Refs: #64214
This reverts commit 8488e13.
@ronag wrote in #64227 (comment)
cc: @Y1D7NG @davidje13