Split oversized test file test/parallel/test-fs-promises-file-handle-writer.js (1117 lines ->170 lines ) - #65384
Open
BboyAkers wants to merge 12 commits into
Open
Split oversized test file test/parallel/test-fs-promises-file-handle-writer.js (1117 lines ->170 lines )#65384BboyAkers wants to merge 12 commits into
BboyAkers wants to merge 12 commits into
Conversation
…romises-file-handle-writer-core.js
….js, forgot to add it before
…that, was silly and over zealous to do tbh
nodejs-github-bot
added
needs-ci
jasnell
reviewed
Aug 18, 2026
| @@ -0,0 +1,81 @@ | |||
| const { | |||
Member
There was a problem hiding this comment.
These need the 'use strict'; at the top and the require('../common')
Member
There was a problem hiding this comment.
These should be caught by running make lint
Member
|
Your commits will need to be squashed to a single commit that has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split oversized test file test/parallel/test-fs-promises-file-handle-writer.js (1117 lines)
Split the code into 5 files:
Was AI used? If yes, why?
Yes, I used AI to:
Sidenote
Everything else, including the code, was broken up by hand and then validated by running the test scripts. For clarity, I also used AI as an additional layer of validation to improve the integrity of this PR, since this is my first PR to Node and wanted ya'lls lives to be as easy as possible while reviewing. I also broke up all the changes per file into individual commits, for clearer version/commit history.