diagnostics_channel: return a disposable from subscribe - #65383
Open
araujogui wants to merge 1 commit into
Open
Conversation
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
araujogui
force-pushed
the
diagnostics-channel-subscribe-disposable
branch
from
August 18, 2026 14:52
cd02941 to
27df399
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65383 +/- ##
==========================================
+ Coverage 90.11% 90.13% +0.01%
==========================================
Files 752 752
Lines 251861 251919 +58
Branches 47365 47373 +8
==========================================
+ Hits 226955 227055 +100
+ Misses 16238 16186 -52
- Partials 8668 8678 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
subscribereturn aDisposableso a subscription can be scoped withusinginstead of pairing each call with a matchingunsubscribe.Applies to
diagnostics_channel.subscribe(),channel.subscribe(),tracingChannel.subscribe(), andboundedChannel.subscribe(). The disposableremoves only the handlers that call registered, and disposing is idempotent.
Existing callers are unaffected — the return value was previously
undefined.