Skip to content

src: remove unused BindingData::LoadEnvFile declaration - #65001

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process
Open

src: remove unused BindingData::LoadEnvFile declaration#65001
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process

Conversation

@Archkon

@Archkon Archkon commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

LoadEnvFile is implemented and registered as a file-local function, not a BindingData static member. Remove the unused member declaration.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (cd78d08) to head (69fcfff).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65001   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files         762      762           
  Lines      247534   247532    -2     
  Branches    46684    46682    -2     
=======================================
+ Hits       223479   223486    +7     
- Misses      15485    15490    +5     
+ Partials     8570     8556   -14     
Files with missing lines Coverage Δ
src/node_process.h 100.00% <ø> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LoadEnvFile is implemented and registered as a file-local function, not
a BindingData static member. Remove the unused member declaration.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants