Skip to content

src: delete cppgc tracking nodes during Realm cleanup - #65000

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:delete-cppgc
Open

src: delete cppgc tracking nodes during Realm cleanup#65000
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:delete-cppgc

Conversation

@Archkon

@Archkon Archkon commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Delete CppgcWrapperListNode instances after finalizing their wrappers to prevent native memory leaks when a Realm is destroyed while wrappers remain alive.

Delete CppgcWrapperListNode instances after finalizing their wrappers to
prevent native memory leaks when a Realm is destroyed while wrappers
remain alive.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (cd78d08) to head (bef1ff8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65000      +/-   ##
==========================================
- Coverage   90.28%   90.26%   -0.02%     
==========================================
  Files         762      762              
  Lines      247534   247537       +3     
  Branches    46684    46692       +8     
==========================================
- Hits       223479   223444      -35     
- Misses      15485    15537      +52     
+ Partials     8570     8556      -14     
Files with missing lines Coverage Δ
src/cppgc_helpers.cc 77.77% <100.00%> (-13.89%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants