Skip to content

ffi: remove dead null check in callback arguments - #64998

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:ffi-invoke-callback-dead-branch
Open

ffi: remove dead null check in callback arguments#64998
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:ffi-invoke-callback-dead-branch

Conversation

@trivikr

@trivikr trivikr commented Aug 4, 2026

Copy link
Copy Markdown
Member

InvokeCallback tested args[i] == nullptr and mapped the argument to JS null. args is libffi's avalue array, and libffi always points each slot at its own storage for the corresponding argument, so the slot pointers are never null and the branch never ran.

The check also read as a guarantee the code does not provide: a NULL pointer argument surfaces as the BigInt 0n, because ToJSArgument converts ffi_type_pointer values with BigInt::NewFromUnsigned. Drop the branch rather than reimplementing it in ToJSArgument, which would change behavior by making pointer parameters arrive as either a BigInt or null.


Assisted-by: claude:opus-5

InvokeCallback tested `args[i] == nullptr` and mapped the argument to
JS `null`. `args` is libffi's avalue array, and libffi always points
each slot at its own storage for the corresponding argument, so the
slot pointers are never null and the branch never ran.

The check also read as a guarantee the code does not provide: a NULL
pointer argument surfaces as the BigInt `0n`, because ToJSArgument
converts `ffi_type_pointer` values with BigInt::NewFromUnsigned. Drop
the branch rather than reimplementing it in ToJSArgument, which would
change behavior by making pointer parameters arrive as either a BigInt
or `null`.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Assisted-by: claude:opus-5
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 4, 2026
@trivikr trivikr added the ffi Issues and PRs related to experimental Foreign Function Interface support. label Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (7946f82) to head (c49d330).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64998      +/-   ##
==========================================
- Coverage   92.02%   90.28%   -1.75%     
==========================================
  Files         399      762     +363     
  Lines      175608   247531   +71923     
  Branches    27107    46689   +19582     
==========================================
+ Hits       161609   223484   +61875     
- Misses      13687    15489    +1802     
- Partials      312     8558    +8246     
Files with missing lines Coverage Δ
src/node_ffi.cc 70.93% <100.00%> (ø)

... and 492 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants