src,doc: clarify OpenSSL FIPS configuration and fix crypto.setFips(0) throw - #64982
Open
panva wants to merge 4 commits into
Open
src,doc: clarify OpenSSL FIPS configuration and fix crypto.setFips(0) throw#64982panva wants to merge 4 commits into
panva wants to merge 4 commits into
Conversation
OpenSSL reports FIPS mode as disabled after a successful EVP_default_properties_enable_fips(..., 0) call. Do not treat that disabled state as a failure. Add OpenSSL 3 regression coverage that verifies the state is enabled before disabling it again. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
A missing OPENSSL_VERSION_NUMBER macro raises TypeError while the configure logic attempts to slice None. Treat that like the other version detection failures so configure warns and records version 0. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
openssl_is_fips is always the string "true" or "false", so testing whether it is non-empty always adds OPENSSL_FIPS to mkssldef. Add the define only when FIPS was requested. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Distinguish OpenSSL 3 provider setup from FIPS/property-query state, document configuration precedence and provider limitations, and retain the OpenSSL 1.1 and runtime control guidance. Regenerate the CLI manpage. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
added
the
commit-queue-rebase
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64982 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01%
==========================================
Files 762 762
Lines 247524 247524
Branches 46684 46683 -1
==========================================
- Hits 223466 223463 -3
- Misses 15490 15491 +1
- Partials 8568 8570 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts and expands the non-breaking FIPS documentation corrections and
crypto.setFips(0)fix from #64777.Clarify how Node.js FIPS controls interact with the OpenSSL 3 provider model.
crypto.setFips(true)only addsfips=yesto the default property query, whilecrypto.getFips()only reports that query state. Neither establishes provider readiness.Document provider installation and startup configuration, configuration precedence, startup validation with
--enable-fipsand--force-fips, runtime-control limitations, OpenSSL 1.1.1 requirements, and the multiple-libcryptoprovider limitation. Correct--openssl-confto--openssl-config, remove the nonexistent./configure --openssl-fipsinstruction, and regenerate the manpage.