Repository navigation
Keep the job name a config sets, and add a job-name input - #12
Merged
Merged
Conversation
run.sh passed --job-name "<job id>-<time>-<random>" on every run, so a config's job_name was always replaced. A job spec that must run under its own name, as a server that checks the job against the spec requires, could not run through the action, and --job-name in args only made hbench reject the duplicate flag. Now a config that sets job_name keeps it: the action reads it (JSON, or YAML with or without PyYAML), passes no --job-name and points job-dir at <jobs-dir>/<job_name>. The new job-name input sets a name of your own. Configs without job_name, path and dataset runs keep the generated name, and the default artifact name is unchanged. --job-name in args is refused with a pointer to job-name. The docs say how to run a spec, that a dataset with no registry comes from hbench's default registry, which of `hbench tasks check` and `hbench check` needs a key, and what a score with n-tasks covers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
job_namenow keeps it. The action passes no--job-name, andjob-diris<jobs-dir>/<job_name>, so a job spec runs under its own name.job-nameinput sets a name of your own.--job-nameinargsis refused with a pointer tojob-name.pathanddatasetruns, and configs withoutjob_name, still run as<job id>-<time>-<random>, and the default artifact name is the same.datasetwithoutregistryuses hbench's default registry.hbench tasks checkneeds no key, buthbench checkdoes. What a score withn-taskscovers. The version examples now show v0.3.5.run-configjob (named, renamed and unnamed configs) and unit tests for readingjob_name.This is a minor release (v1.2.0): it adds an input, and changes the job name only for configs that set one.