Skip to content

test: use node:crypto randomUUID instead of uuid dependency #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 1 commit into from
Aug 5, 2026
+155 −156
Merged

test: use node:crypto randomUUID instead of uuid dependency #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@
"eslint-config-egg": "12",
"mm": "^2.0.0",
"mz-modules": "^2.1.0",
"typescript": "5",
"uuid": "^3.0.1"
"typescript": "5"
},
"engines": {
"node": ">= 18.0.0"
Expand Down
12 changes: 6 additions & 6 deletions test/gzip/file_stream.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const fs = require('fs');
const os = require('os');
const path = require('path');
const uuid = require('uuid');
const { randomUUID } = require('node:crypto');
const { pipeline: pump } = require('stream');
const compressing = require('../..');
const assert = require('assert');
Expand All @@ -10,7 +10,7 @@ describe('test/gzip/file_stream.test.js', () => {
it('should be a transform stream', done => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const sourceStream = fs.createReadStream(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log.gz');
// console.log('destFile', destFile);
const gzipStream = new compressing.gzip.FileStream();
const destStream = fs.createWriteStream(destFile);
Expand All @@ -23,7 +23,7 @@ describe('test/gzip/file_stream.test.js', () => {

it('should compress according to file path', done => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log.gz');
// console.log('destFile', destFile);
const gzipStream = new compressing.gzip.FileStream({ source: sourceFile });
const destStream = fs.createWriteStream(destFile);
Expand All @@ -42,15 +42,15 @@ describe('test/gzip/file_stream.test.js', () => {
gzipChunks.push(chunk);
}

const destFile = path.join(os.tmpdir(), uuid.v4() + '.log.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log.gz');
await fs.promises.writeFile(destFile, Buffer.concat(gzipChunks));
// console.log(destFile);
});

it('should compress buffer', done => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const sourceBuffer = fs.readFileSync(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log.gz');
// console.log('destFile', destFile);
const destStream = fs.createWriteStream(destFile);
const gzipStream = new compressing.gzip.FileStream({ source: sourceBuffer });
Expand All @@ -65,7 +65,7 @@ describe('test/gzip/file_stream.test.js', () => {
it('should compress stream', done => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const sourceStream = fs.createReadStream(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log.gz');
// console.log('destFile', destFile);
const destStream = fs.createWriteStream(destFile);
const gzipStream = new compressing.gzip.FileStream({ source: sourceStream });
Expand Down
20 changes: 10 additions & 10 deletions test/gzip/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const fs = require('fs');
const os = require('os');
const path = require('path');
const uuid = require('uuid');
const { randomUUID } = require('node:crypto');
const compressing = require('../..');
const assert = require('assert');
const isWindows = os.platform() === 'win32';
Expand All @@ -12,7 +12,7 @@ describe('test/gzip/index.test.js', () => {
describe('gzip.compressFile()', () => {
it('gzip.compressFile(file, stream)', async () => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log.gz');
// console.log('destFile', destFile);
const fileStream = fs.createWriteStream(destFile);
await compressing.gzip.compressFile(sourceFile, fileStream);
Expand All @@ -21,7 +21,7 @@ describe('test/gzip/index.test.js', () => {

it('gzip.compressFile(file, destStream) should error if destStream emit error', async () => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const destFile = path.join(os.tmpdir(), uuid.v4() + '.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.gz');
const fileStream = fs.createWriteStream(destFile);
setImmediate(() => fileStream.emit('error', new Error('xx')));

Expand All @@ -37,7 +37,7 @@ describe('test/gzip/index.test.js', () => {
it('gzip.compressFile(buffer, stream)', async () => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const sourceBuffer = fs.readFileSync(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log.gz');
// console.log('destFile', destFile);
const fileStream = fs.createWriteStream(destFile);
await compressing.gzip.compressFile(sourceBuffer, fileStream);
Expand All @@ -47,7 +47,7 @@ describe('test/gzip/index.test.js', () => {
it('gzip.compressFile(sourceStream, destStream)', async () => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const sourceStream = fs.createReadStream(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log.gz');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log.gz');
// console.log('destFile', destFile);
const fileStream = fs.createWriteStream(destFile);
await compressing.gzip.compressFile(sourceStream, fileStream);
Expand All @@ -59,7 +59,7 @@ describe('test/gzip/index.test.js', () => {
it('gzip.uncompress(sourceFile, destStream)', async () => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log.gz');
const originalFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');
const fileStream = fs.createWriteStream(destFile);
await compressing.gzip.uncompress(sourceFile, fileStream);
assert(fs.existsSync(destFile));
Expand All @@ -72,7 +72,7 @@ describe('test/gzip/index.test.js', () => {
it('gzip.uncompress(sourceStream, destStream)', async () => {
const sourceStream = fs.createReadStream(path.join(__dirname, '..', 'fixtures', 'xx.log.gz'));
const originalFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');
const fileStream = fs.createWriteStream(destFile);
await compressing.gzip.uncompress(sourceStream, fileStream);
assert(fs.existsSync(destFile));
Expand All @@ -85,7 +85,7 @@ describe('test/gzip/index.test.js', () => {
it('gzip.uncompress(sourceStream, destFile)', async () => {
const sourceStream = fs.createReadStream(path.join(__dirname, '..', 'fixtures', 'xx.log.gz'));
const originalFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');
await compressing.gzip.uncompress(sourceStream, destFile);
assert(fs.existsSync(destFile));
if (!isWindows) {
Expand All @@ -97,7 +97,7 @@ describe('test/gzip/index.test.js', () => {
it('gzip.uncompress(sourceFile, destFile)', async () => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log.gz');
const originalFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');
await compressing.gzip.uncompress(sourceFile, destFile);
assert(fs.existsSync(destFile));
if (!isWindows) {
Expand All @@ -109,7 +109,7 @@ describe('test/gzip/index.test.js', () => {
it('gzip.uncompress(buffer, destFile)', async () => {
const sourceBuffer = fs.readFileSync(path.join(__dirname, '..', 'fixtures', 'xx.log.gz'));
const originalFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');
await compressing.gzip.uncompress(sourceBuffer, destFile);
assert(fs.existsSync(destFile));
if (!isWindows) {
Expand Down
10 changes: 5 additions & 5 deletions test/gzip/uncompress_stream.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const fs = require('fs');
const mm = require('mm');
const os = require('os');
const uuid = require('uuid');
const { randomUUID } = require('node:crypto');
const path = require('path');
const assert = require('assert');
const { pipeline: pump } = require('stream');
Expand All @@ -16,7 +16,7 @@ describe('test/gzip/uncompress_stream.test.js', () => {
afterEach(mm.restore);

it('should be transform stream', done => {
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');

const sourceStream = fs.createReadStream(sourceFile);
const uncompressStream = new compressing.gzip.UncompressStream();
Expand All @@ -36,7 +36,7 @@ describe('test/gzip/uncompress_stream.test.js', () => {
});

it('should uncompress according to file path', done => {
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');

const uncompressStream = new compressing.gzip.UncompressStream({ source: sourceFile });
const destStream = fs.createWriteStream(destFile);
Expand All @@ -55,7 +55,7 @@ describe('test/gzip/uncompress_stream.test.js', () => {

it('should uncompress buffer', done => {
const sourceBuffer = fs.readFileSync(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');

const destStream = fs.createWriteStream(destFile);
const uncompressStream = new compressing.gzip.UncompressStream({ source: sourceBuffer });
Expand All @@ -74,7 +74,7 @@ describe('test/gzip/uncompress_stream.test.js', () => {

it('should uncompress stream', done => {
const sourceStream = fs.createReadStream(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.log');
const destFile = path.join(os.tmpdir(), randomUUID() + '.log');

const destStream = fs.createWriteStream(destFile);
const uncompressStream = new compressing.gzip.UncompressStream({ source: sourceStream });
Expand Down
6 changes: 3 additions & 3 deletions test/tar/file_stream.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const mm = require('mm');
const fs = require('fs');
const os = require('os');
const path = require('path');
const uuid = require('uuid');
const { randomUUID } = require('node:crypto');
const assert = require('assert');
const { pipeline: pump } = require('stream');
const compressing = require('../..');
Expand All @@ -14,7 +14,7 @@ describe('test/tar/file_stream.test.js', () => {
it('tar.FileStream without size', done => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const sourceStream = fs.createReadStream(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.tar');
const destFile = path.join(os.tmpdir(), randomUUID() + '.tar');
// console.log('dest', destFile);

mm(console, 'warn', msg => {
Expand All @@ -33,7 +33,7 @@ describe('test/tar/file_stream.test.js', () => {
it('tar.FileStream with size', done => {
const sourceFile = path.join(__dirname, '..', 'fixtures', 'xx.log');
const sourceStream = fs.createReadStream(sourceFile);
const destFile = path.join(os.tmpdir(), uuid.v4() + '.tar');
const destFile = path.join(os.tmpdir(), randomUUID() + '.tar');
// console.log('dest', destFile);

mm(console, 'warn', msg => {
Expand Down
Loading
Loading