Repository navigation
Fit MSD Observer to screen with focused, non-repetitive tabs - #6
Merged
Merged
Conversation
✅ Deploy Preview for msd-observer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the authenticated MSD Observer fit the available screen on phone and desktop. The previous layout only fitted the phone Overview; other views stacked content below the screen. Every observer view now uses focused sub-views and pagination, with one home for each type of information.
Phone preview · Desktop preview · Navigation / Netlify / iPhone guide. Images use explicitly simulated browser fixtures, not real driver data.
Passed locally: build/TypeScript, formatting, standalone demo generation, 84 unit/integration tests, 42 browser tests, and 3 production PWA tests. Layout checks visit every content view at 320×568, 375×667, 390×844, 667×375, 844×390 and 1440×900; they check actual page/panel overflow and control/data bounds, not just hidden scrollbars. Tests also traverse every item in long collections, check keyboard-sized editing, canonical data homes/sensor-report links, owner/observer permissions, create/complete sessions, Realtime ordering/deduplication, missing readings/GPS, custom ranges, history/export, offline recovery and worker non-caching. Browser suites use isolated output directories; no artifact-collision failures occurred.
Supabase schema/backend/authorization hooks, phone gateway, firmware, Netlify configuration and PWA network-only caching policy are unchanged. Built assets were checked for configured private test identities/passwords and browser fixture identities; none are included. Physical iPhone/Safari installation and keyboard behavior still require the final deployed domain and the guide's device checks; automated tests use Chromium.
This updates existing PR #6; no PR #7 was created and nothing was merged or explicitly deployed. Do not merge automatically.