Skip to content

Enable codegen for ni-rfsa - #2195

Open
mohit-emerson wants to merge 7 commits into
ni:masterfrom
mohit-emerson:rfsa_python_codegen
Open

Enable codegen for ni-rfsa #2195
mohit-emerson wants to merge 7 commits into
ni:masterfrom
mohit-emerson:rfsa_python_codegen

Conversation

@mohit-emerson

@mohit-emerson mohit-emerson commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md.
  • [] I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Added ni-rfsa to tox build, MakeFile.
  • Added ni-rfsa Unit tests, System tests, examples.
  • Added code generated files.
  • Added ni-rfsa to github actions.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

  • PR Validations
  • Tested on real hardware & simulated hardware. All tests are successful.

@mohit-emerson
mohit-emerson marked this pull request as ready for review August 14, 2026 09:47
@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.69177% with 317 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.50%. Comparing base (5f12b7a) to head (e0c07d0).

Files with missing lines Patch % Lines
generated/nirfsa/nirfsa/_library_interpreter.py 77.96% 145 Missing ⚠️
generated/nirfsa/nirfsa/_library.py 81.96% 110 Missing ⚠️
generated/nirfsa/nirfsa/spectrum_info_type.py 60.71% 22 Missing ⚠️
generated/nirfsa/nirfsa/waveform_info.py 61.40% 22 Missing ⚠️
generated/nirfsa/nirfsa/coefficient_info_type.py 43.75% 18 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2195      +/-   ##
==========================================
- Coverage   89.32%   88.50%   -0.82%     
==========================================
  Files          73       80       +7     
  Lines       19048    21380    +2332     
==========================================
+ Hits        17014    18922    +1908     
- Misses       2034     2458     +424     
Flag Coverage Δ
codegenunittests 84.90% <ø> (ø)
nidcpowersystemtests 94.38% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.02% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.29% <ø> (ø)
nifakeunittests 86.01% <ø> (ø)
nifgensystemtests 94.32% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 81.77% <77.69%> (?)
nirfsgsystemtests 81.12% <ø> (ø)
niscopesystemtests 89.96% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.56% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nirfsa/nirfsa/_complextype.py 100.00% <100.00%> (ø)
generated/nirfsa/nirfsa/session.py 88.14% <ø> (ø)
generated/nirfsa/nirfsa/coefficient_info_type.py 43.75% <43.75%> (ø)
generated/nirfsa/nirfsa/spectrum_info_type.py 60.71% <60.71%> (ø)
generated/nirfsa/nirfsa/waveform_info.py 61.40% <61.40%> (ø)
generated/nirfsa/nirfsa/_library.py 81.96% <81.96%> (ø)
generated/nirfsa/nirfsa/_library_interpreter.py 77.96% <77.96%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f12b7a...e0c07d0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants