feat: CC0 controller sounds and hover feedback - #296
Merged
Merged
Conversation
Replaces the synthesized cues with four Kenney CC0 sounds (trimmed, equal energy); adds a neutral, mouse-only hover state everywhere something is clickable. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287. Closes #295.
#287 The synthesized cues were still judged unsatisfactory, so they are replaced by sounds from a licensed library: four short cues from Kenney's Interface Sounds pack (CC0 1.0, redistribution free;
assets/sounds/LICENSE-Kenney-CC0.txt, THIRD_PARTY_NOTICES.md).tools/make-sounds.pyturned select_002 (move), glass_006 (mark), confirmation_001 (confirm) and back_004 (back) into mono 44.1 kHz WAVs: trimmed, 2 ms fades, equal RMS, peak-capped; embedded inControlFS.Core.SoundBankapplies only the user's volume (perceptual curve), so enable/disable and volume settings are unchanged. The four were picked by spectral analysis (short, tonal, low brightness), not by ear: I could not listen, so final taste is for a human to confirm (manual checks in docs/TESTING.md).#295 Hover feedback via
Hover(App/Controls) + three theme tokens (HoverWash,HoverInset,HoverCard, derived from the palette text colour: lighten in dark, darken in light; never the accent). Applied centrally inTheme.ApplyFocus/ApplyCardFocus(list/grid rows, tabs, breadcrumbs, quick access, cards), to modal tiles/icon tiles/rows, keyboard keys and suggestions, column headers and tutorial controls. Guards: no hover on the focused item or disabled ones; only while the mouse moved within 1.5 s, so scrolling with the controller under a stationary pointer lights nothing (the #182 problem); touch ignored; handlers registered once per element (recycled rows don't accumulate).Tests: SoundBank WAV validity/volume curve/equal loudness/silent edges. Hover is visual (manual checks added). Full smoke on this branch (embedded resources + Theme used everywhere).
🤖 Generated with Claude Code